Skip to content

Don't skip all actions on version update PRs, because it also skips automerge - #1806

Merged
Jag96 merged 1 commit into
masterfrom
Rory-DontSkipAutomerge
Mar 16, 2021
Merged

Jag96 merged 1 commit into
masterfrom
Rory-DontSkipAutomerge

Conversation

@roryabraham

Copy link
Copy Markdown
Contributor

Details

This PR added some code to skip all Github Actions on automatically generated version-bump PRs, because we never wait for tests to finish on those anyways. However, this also skips the automerge workflow, which prevents the master branch from actually being updated.

Merge to test

@roryabraham
roryabraham requested a review from Jag96 March 16, 2021 22:47
@roryabraham roryabraham self-assigned this Mar 16, 2021
@roryabraham
roryabraham requested a review from a team as a code owner March 16, 2021 22:47
@botify
botify requested review from jasperhuangg and removed request for a team March 16, 2021 22:47
@Jag96

Jag96 commented Mar 16, 2021

Copy link
Copy Markdown
Contributor

Merging to unbreak e.cash deploys

@Jag96
Jag96 merged commit 54599a2 into master Mar 16, 2021
@Jag96
Jag96 deleted the Rory-DontSkipAutomerge branch March 16, 2021 22:55
@botify

botify commented Mar 16, 2021

Copy link
Copy Markdown

@Jag96 looks like this was merged without passing tests. Please add a note explaining why this was done or remove the Emergency label if this is not an emergency.

@Jag96 Jag96 removed the Emergency label Mar 16, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 16, 2021
@roryabraham

Copy link
Copy Markdown
Contributor Author

We merged early to unbreak deploys.

It looks like this was successful in triggering the automerge workflow on the version-bump PR as expected. However, the automerge did not re-trigger the preDeploy workflow to update staging, so the deploy didn't complete.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants