Repository navigation
migrate CopyTextToClipboard to functional component #20107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
PauloGasparSv
merged 8 commits into
Expensify:main
from
nhminhduc:16132-migrate-CopyTextToClipboard
Jun 7, 2023
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
99bbff8
migrate CopyTextToClipboard to functional component
nhminhduc 14ae86d
Move props to bottom
nhminhduc 3ef6eaa
Remove space between before and after curly brackets, use props inste…
nhminhduc 4154ccf
Update with main, using PressableWithDelayToggle instead
nhminhduc 549a1a3
Merge branch 'main' into 16132-migrate-CopyTextToClipboard
nhminhduc 82c701d
Merge branch 'main' of github.com:nhminhduc/Expensify into 16132-migr…
nhminhduc f5ff404
Fix lint, useCallback for copyToClipboard, add displayName = CopyText…
nhminhduc 736a620
Run prettier
nhminhduc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nhminhduc @PauloGasparSv Do you guys agree if we wrap this with
useCallbacksince it has dependencies ofprops.text?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I agree