Repository navigation
New group can't search an email if it's a substring of a selected email - #23982
Conversation
|
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@abdulrahuman5196 ICYMI. Please help review the PR |
|
@dukenv0307 Thanks for the ping, Yes will review this is one hour. Just to confirm, we checked this issue not coming up in other search pages right? |
|
@abdulrahuman5196 I just checked other search pages and see that It works well |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-08-02.at.10.28.34.PM.mp4Mobile Web - Chromeaz_recorder_20230802_224631.mp4Mobile Web - SafariUntitled.1.mp4DesktopScreen.Recording.2023-08-02.at.10.36.34.PM.mp4iOSScreen.Recording.2023-08-02.at.10.51.23.PM.mp4AndroidScreen.Recording.2023-08-02.at.11.04.09.PM.mp4 |
abdulrahuman5196
left a comment
There was a problem hiding this comment.
Changes looks good and works well. Reviewers checklist is also complete.
All yours. @tgolen
🎀 👀 🎀
C+ Reviewed
|
Gentle ping on this @tgolen |
|
@tgolen ICYMI. Please help review the PR |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/tgolen in version: 1.3.51-0 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.51-2 🚀
|
|
🚀 Deployed to staging by https://github.com/tgolen in version: 1.3.52-0 🚀
|
|
🚀 Deployed to staging by https://github.com/tgolen in version: 1.3.52-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.52-5 🚀
|
| [], | ||
| selectedOptions, |
There was a problem hiding this comment.
This caused a regression #26072. We used to pass an empty array so we get a non-empty userToInvite. The userToInvite was used in getHeaderMessage not to return unwanted error messages.
Details
Web - New group can't search an email if it's a substring of a selected email
Fixed Issues
$ #23503
PROPOSAL: #23503 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
web.mp4
Mobile Web - Chrome
chrome.mov
Mobile Web - Safari
safari.mov
Desktop
desktop.mov
iOS
ios.mov
Android
android.mov