Repository navigation
[CP staging] Followup/23961 edit request - #24565
Conversation
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
mountiny
left a comment
There was a problem hiding this comment.
Looking great so far, added few comments
Reviewer Checklist
Screenshots/VideosWebweb24565.mp4Mobile Web - ChromeandroidChrome24565.mp4Mobile Web - Safarisafari24565.mp4DesktopiOSAndroid |
|
Could you please merge with main? After merging locally I am getting this NaN in the message. Screen.Recording.2023-08-16.at.23.23.52.movAlso there might be some other issues now as we are using the transactions data |
|
@mountiny the problem still persists after merging with main - we're still using originalMessage in getModifiedExpenseMessage (it's still on main). I don't know if this function should be removed or some merge conflicts were resolved inappropriately, but I think it should be handled in another PR. WDYT? |
Screen.Recording.2023-08-17.at.11.09.20.mp4after this fix everything is being updated correctly |
We should be using the originalMessage from the MODIFIEDEXPENSE action, we are only using the transaction data in case of the IOU actions |
|
I am having issues running Android and iOS locally |
|
iOS and Andoird work well 👍 iOSios.movAndroidandroid.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[CP staging] Followup/23961 edit request (cherry picked from commit 2de126f)
|
🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.55-1 🚀
|


Details
Fixed Issues
$ #23961
$ #25386
$ #25388
$ #25390
PROPOSAL: #23961
Tests
Offline tests
n/a
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Screen.Recording.2023-08-11.at.12.49.36.mp4
Mobile Web - Chrome
Untitled.mp4
Mobile Web - Safari
iphone.saf.mov
Desktop
Screen.Recording.2023-08-11.at.14.42.00.mp4
iOS
iphone.app.mov
Android
Screen.Recording.2023-08-11.at.15.08.26.mp4