Repository navigation
[TS migration] Migrate 'LoginUtils.js' lib to TypeScript - #27257
AndrewGable merged 6 commits into
Conversation
4276839 to
eb144ac
Compare
|
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #24834 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
Co-authored-by: Fábio Henriques <fabio.lacerda@outlook.com>
fabioh8010
left a comment
There was a problem hiding this comment.
LGTM, CK still need to do the checklist.
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-09-19.at.12.07.00.movScreen.Recording.2023-09-19.at.12.08.31.movDesktopScreen.Recording.2023-09-19.at.12.08.55.movMobile Web - ChromeScreen.Recording.2023-09-19.at.12.09.38.movAndroidScreen.Recording.2023-09-19.at.12.10.46.movMobile Web - SafariScreen.Recording.2023-09-19.at.12.12.18.moviOSScreen.Recording.2023-09-19.at.12.12.54.mov |
|
Can you write a few QA tests to confirm this isn't going to add a regression? Thanks! |
|
@AndrewGable done ✅ |
|
@kowczarz We have lint errors here |
511bc64 to
8f4994e
Compare
|
I'm not seeing the QA tests and we should remove the |
|
@AndrewGable Kamil is OOO this week, he'll add QA steps and adjust the title next week. |
|
@AndrewGable done ✅ |
AndrewGable
left a comment
There was a problem hiding this comment.
Thanks for adding tests!
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.3.77-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀
|
Details
Fixed Issues
$ #24834
Tests
Offline tests
QA Steps
Wrong email:
Correct email:
Phone with country code:
Phone without country code:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
web.mov
Mobile Web - Chrome
Mobile Web - Safari
ios.web.mp4
Desktop
desktop.mov
iOS
ios.native.mp4
Android
[android.webm](https://github.com/Expensify/App/assets/91068263/6efd727d-e5c7-416a-8e47-989ef5a32917)