Repository navigation
fix issue 27333 - #27727
Merged
Merged
fix issue 27333#27727
Conversation
melvin-bot
Bot
requested review from
allroundexperts
and removed request for
a team
September 19, 2023 00:44
|
@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
1 of 6 tasks
Contributor
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-09-20.at.12.04.06.AM.movMobile Web - ChromeScreen.Recording.2023-09-20.at.12.08.19.AM.movMobile Web - SafariScreen.Recording.2023-09-20.at.12.05.32.AM.movDesktopScreen.Recording.2023-09-20.at.12.12.33.AM.moviOSScreen.Recording.2023-09-20.at.12.06.43.AM.movAndroidScreen.Recording.2023-09-20.at.12.09.55.AM.mov |
marcochavezf
approved these changes
Sep 20, 2023
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.3.72-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.72-11 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #27333
PROPOSAL: #27333 (comment)
Tests
Offline tests
N/A.
QA Steps
Same as Tests step.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
20230919023819161.mp4
Mobile Web - Chrome
20230919000639106.mp4
Mobile Web - Safari
20230919001930094.mp4
Desktop
20230919002143451.mp4
iOS
20230919001819318.mp4
Android
20230919000819199.mp4