Repository navigation
Fix - User is hard to close a Phone account if it contains spaces - #27818
Conversation
|
@robertKozik Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Quick bump @robertKozik on code review |
|
Bump @robertKozik again ^. |
|
@robertKozik, can you take a look at this? |
|
@Gonals Sure, I had one question to the |
@robertKozik I couldn't find this question. Could you link me to the question? Thanks |
| * @param {String} phoneOrEmail - The input string to be sanitized. | ||
| * @returns {String} The sanitized string | ||
| */ | ||
| const sanitizePhoneOrEmail = (phoneOrEmail) => phoneOrEmail.replace(/\s+/g, '').toLowerCase(); |
There was a problem hiding this comment.
@hoangzinh Just thinking, can't we use already defined formatPhoneNumber or use parsePhoneNumber from awasome-phonenumber? Just throwing ideas 🤔
There was a problem hiding this comment.
Ah because those comparisons are only scoped in the context of Close account page. I don't think we can reuse any existing lib in this case.
Sorry you probably didn't saw that because the review is not submitted. Here you go #27818 (comment) |
Reviewer Checklist
Screenshots/VideosWebweb.movMobile Web - Chromeios.-.android.-.web.movMobile Web - Safariios.-.android.-.web.movDesktopdesktop.moviOSandroid.-.ios.-.native.movAndroidandroid.-.ios.-.native.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Gonals in version: 1.3.77-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀
|
Details
Fixed Issues
$ #27283
PROPOSAL: #27283 (comment)
Tests
Offline tests
PR changes are not affected by Network status
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Screen.Recording.2023-09-20.at.10.18.00.-.web.mp4
Mobile Web - Chrome
Screen.Recording.2023-09-20.at.10.31.02.-.android.chrome.mp4
Mobile Web - Safari
Screen.Recording.2023-09-20.at.10.35.06.-.ios.safari.mov
Desktop
Screen.Recording.2023-09-20.at.10.22.55.-.desktop.mov
iOS
Screen.Recording.2023-09-20.at.10.33.47.-.ios.mp4
Android
Screen.Recording.2023-09-20.at.10.53.25.-.android.mp4