Repository navigation
refactor: migrated IdologyQuestions to the function component - #28123
MonilBhavsar merged 5 commits into
Conversation
d1e55e7 to
1312af9
Compare
|
For any C+ assigned, making this an internalQA to test in staging |
|
@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@mountiny was C+ supposed to be assigned here for first pass? |
|
Yes Arek is ooo so it did not assign him |
Reviewer Checklist
Screenshots/VideosWebweb.movMobile Web - Chromeandorid-web.movMobile Web - Safariios-web.movDesktopdesktop.moviOSios.movAndroidandroid.mov |
|
@barttom Bottom Button size is broken for all platforms - can you please check: |
|
@mountiny also on ios native we have too much space at the top - maybe we can fix it with this PR? |
|
Thanks for review. I would vote to fix in this PR |
1312af9 to
89ae1bc
Compare
|
@narefyev91 |
narefyev91
left a comment
There was a problem hiding this comment.
LGTM!
🎀 👀 🎀 C+ reviewed
|
🎯 @narefyev91, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #28301. |
ebc57c6 to
e421d64
Compare
|
@narefyev91 could you please help to review and probably retest since commits are force pushed |
Re-tested - get the same correct screens - for all platforms |
|
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.3.77-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀
|




Details
Fixed Issues
$ #16233
PROPOSAL: #16233
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
16233_web.mov
Mobile Web - Chrome
16233_mobile_web_chrome.mov
Mobile Web - Safari
16233_mobile_web_safari.mov
Desktop
iOS
16233_ios.mov
Android
16233_android.mov