Repository navigation
fix: Chat - Space is not added after an emoji is selecte - #28302
Merged
Merged
Conversation
Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>
Contributor
Author
|
@jjcoffee, friendly bump. |
Contributor
Reviewer Checklist
Screenshots/VideosWebchrome-desktop-2023-09-28_18.05.50.mp4Mobile Web - Chromeandroid-chrome.mp4Mobile Web - Safariios-safari-2023-09-28_17.44.55.mp4Desktopmac-desktop-2023-09-28_17.42.39.mp4iOSios-native-2023-09-28_17.44.04.mp4Androidandroid-native.mp4 |
Contributor
|
Sorry having build issues with Android, will finish the review tomorrow! |
Contributor
Author
|
@joelbettner, friendly bump to merge this one. |
Contributor
Author
|
@joelbettner, bump. |
joelbettner
approved these changes
Oct 3, 2023
|
@joelbettner looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Deployed to staging by https://github.com/joelbettner in version: 1.3.77-0 🚀
|
Closed
2 of 6 tasks
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #26709
PROPOSAL: #26709 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
web_chrome.mp4
Mobile Web - Chrome
android_chrome.mp4
Mobile Web - Safari
ios_safari.mp4
Desktop
desktop_app.mp4
iOS
ios_native.mp4
Android
android_native.mp4