Repository navigation
Fix: @__fake__ shows in task preview with no assignee - #28684
Conversation
|
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
abdulrahuman5196
left a comment
There was a problem hiding this comment.
Changes looks good and works well. Reviewers checklist is also complete.
All yours. @Julesssss
🎀 👀 🎀
C+ Reviewed
|
Hey @abdulrahuman5196, we're missing the checklist 😄 |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-10-03.at.3.09.23.PM.mp4Mobile Web - ChromeScreen.Recording.2023-10-03.at.3.12.10.PM.mp4Mobile Web - SafariScreen.Recording.2023-10-03.at.3.10.34.PM.mp4DesktopScreen.Recording.2023-10-03.at.3.20.02.PM.mp4iOSScreen.Recording.2023-10-03.at.3.13.40.PM.mp4AndroidScreen.Recording.2023-10-03.at.3.15.35.PM.mp4 |
|
@tienifr For Offline tests also kindly mark |
|
OOPS, sorry @Julesssss. Missed to comment the drafts 😵💫 |
abdulrahuman5196
left a comment
There was a problem hiding this comment.
Changes looks good and works well. Reviewers checklist is also complete.
All yours. @Julesssss
🎀 👀 🎀
C+ Reviewed
|
No problem 😄 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.77-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀
|
Details
@__fake__shows in task preview with no assignee. This PR fixes that.Fixed Issues
$ #28055
PROPOSAL: #28055 (comment)
Tests
@__fake__shows on task previewOffline tests
Same as Tests
QA Steps
@__fake__shows on task previewPR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
web-compressed.mov
Mobile Web - Chrome
chrome-compressed.mov
Mobile Web - Safari
safari-compressed.mov
Desktop
desk-compressed.mov
iOS
ios-compressed.mov
Android
android-compressed.mov