Skip to content

fix: add null check to emoji suggestions #31072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pecanoro merged 2 commits into from
Nov 8, 2023
Merged

fix: add null check to emoji suggestions #31072

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f521697
fix: add null check to emoji suggestions
allroundexperts Nov 8, 2023
ebff8c8
fix: lint issues
allroundexperts Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/pages/home/report/ReportActionCompose/Suggestions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,23 @@ function Suggestions({
const suggestionEmojiRef = useRef(null);
const suggestionMentionRef = useRef(null);

const getSuggestions = useCallback(() => suggestionEmojiRef.current.getSuggestions() || suggestionMentionRef.current.getSuggestions(), []);
const getSuggestions = useCallback(() => {
if (suggestionEmojiRef.current && suggestionEmojiRef.current.getSuggestions) {
const emojiSuggestions = suggestionEmojiRef.current.getSuggestions();
if (emojiSuggestions.length > 0) {
return emojiSuggestions;
}
}

if (suggestionMentionRef.current && suggestionMentionRef.current.getSuggestions) {
const mentionSuggestions = suggestionMentionRef.current.getSuggestions();
if (mentionSuggestions.length > 0) {
return mentionSuggestions;
}
}

return [];
}, []);

/**
* Clean data related to EmojiSuggestions
Expand Down