Repository navigation
Fix/30378: Update correct pendingFields #31172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
3ff8093
1f75c95
3a9c613
4043d4f
1147862
4516ed2
1b7fc3a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -686,7 +686,7 @@ describe('actions/IOU', () => { | |
| waitForCollectionCallback: true, | ||
| callback: (transaction) => { | ||
| Onyx.disconnect(connectionID); | ||
| expect(transaction.pendingAction).toBe(CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD); | ||
| expect(transaction.pendingAction).toBeFalsy(); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why the pending action changed to false instead of add?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @ArekChr In this UT case, there are some errors while creating transaction. We removed pendingAction in FailureData in the logic so we also need to update UTs here |
||
| expect(transaction.errors).toBeTruthy(); | ||
| expect(_.values(transaction.errors)[0]).toBe('iou.error.genericCreateFailureMessage'); | ||
| resolve(); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In here we should update pendingFields.waypoints like we did when changing waypoint in EditRequestPage
App/src/libs/actions/IOU.js
Line 689 in 0888bda
I log pendingFields here anh Let's see this video
Screen-Recording-2023-11-10-at-14.57.38.mp4