Repository navigation
[TS Migration] Migrate LogOutPreviousUserPage to TS #34777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a0dcf26
Migrate LogOutPreviousUserPage to TS
roryabraham 1a58bfb
Remove unnecessary change
roryabraham 4f0b857
Merge branch 'main' into Rory-TSMigrateLogOutPreviousUser
roryabraham 56103e7
Default email and shortLivedAuthToken to empty string
roryabraham 21711bc
Delete js page
roryabraham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| import type {StackScreenProps} from '@react-navigation/stack'; | ||
| import React, {useEffect} from 'react'; | ||
| import {Linking} from 'react-native'; | ||
| import {withOnyx} from 'react-native-onyx'; | ||
| import type {OnyxEntry} from 'react-native-onyx'; | ||
| import FullScreenLoadingIndicator from '@components/FullscreenLoadingIndicator'; | ||
| import * as SessionUtils from '@libs/SessionUtils'; | ||
| import type {AuthScreensParamList} from '@navigation/types'; | ||
| import * as SessionActions from '@userActions/Session'; | ||
| import ONYXKEYS from '@src/ONYXKEYS'; | ||
| import type SCREENS from '@src/SCREENS'; | ||
| import type {Session} from '@src/types/onyx'; | ||
|
|
||
| type LogOutPreviousUserPageOnyxProps = { | ||
| /** The data about the current session which will be set once the user is authenticated and we return to this component as an AuthScreen */ | ||
| session: OnyxEntry<Session>; | ||
| }; | ||
|
|
||
| type LogOutPreviousUserPageProps = LogOutPreviousUserPageOnyxProps & StackScreenProps<AuthScreensParamList, typeof SCREENS.TRANSITION_BETWEEN_APPS>; | ||
|
|
||
| // This page is responsible for handling transitions from OldDot. Specifically, it logs the current user | ||
| // out if the transition is for another user. | ||
| // | ||
| // This component should not do any other navigation as that handled in App.setUpPoliciesAndNavigate | ||
| function LogOutPreviousUserPage({session, route}: LogOutPreviousUserPageProps) { | ||
| useEffect(() => { | ||
| Linking.getInitialURL().then((transitionURL) => { | ||
| const sessionEmail = session?.email; | ||
| const isLoggingInAsNewUser = SessionUtils.isLoggingInAsNewUser(transitionURL ?? undefined, sessionEmail); | ||
|
|
||
| if (isLoggingInAsNewUser) { | ||
| SessionActions.signOutAndRedirectToSignIn(); | ||
| } | ||
|
|
||
| // We need to signin and fetch a new authToken, if a user was already authenticated in NewDot, and was redirected to OldDot | ||
| // and their authToken stored in Onyx becomes invalid. | ||
| // This workflow is triggered while setting up VBBA. User is redirected from NewDot to OldDot to set up 2FA, and then redirected back to NewDot | ||
| // On Enabling 2FA, authToken stored in Onyx becomes expired and hence we need to fetch new authToken | ||
| const shouldForceLogin = route.params.shouldForceLogin === 'true'; | ||
| if (shouldForceLogin) { | ||
| const email = route.params.email ?? ''; | ||
| const shortLivedAuthToken = route.params.shortLivedAuthToken ?? ''; | ||
| SessionActions.signInWithShortLivedAuthToken(email, shortLivedAuthToken); | ||
| } | ||
| }); | ||
|
|
||
| // We only want to run this effect once on mount (when the page first loads after transitioning from OldDot) | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, []); | ||
|
|
||
| return <FullScreenLoadingIndicator />; | ||
| } | ||
|
|
||
| LogOutPreviousUserPage.displayName = 'LogOutPreviousUserPage'; | ||
|
|
||
| export default withOnyx<LogOutPreviousUserPageProps, LogOutPreviousUserPageOnyxProps>({ | ||
| session: { | ||
| key: ONYXKEYS.SESSION, | ||
| }, | ||
| })(LogOutPreviousUserPage); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.