Replace usages of isInModal and shouldShowSmallScreen props in components by rayane-d · Pull Request #34837 · Expensify/App

rayane-d · 2024-01-19T20:01:18Z

Details

Replace usages of isInModal and shouldShowSmallScreen props in components
#30528 (comment)

Fixed Issues

$ #30528

Tests

Logout if you are logged in
Verify that the login page is displayed correctly (as before)

Testable on web and mweb only:

Logout from the application.
Try to access any public room(eg. https://dev.new.expensify.com:8082/r/3207869973997783).
Click on sign in button either from header or footer and it opens the sign page in modal and it looks proper.
Scroll down and verify the footer of the sign in page looks proper and items are aligned vertically.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Logout if you are logged in
Verify that the login page is displayed correctly (as before)

Testable on web and mweb only:

Logout from the application.
Try to access any public room(eg. https://staging.new.expensify.com:8082/r/3207869973997783).
Click on sign in button either from header or footer and it opens the sign page in modal and it looks proper.
Scroll down and verify the footer of the sign in page looks proper and items are aligned vertically.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.Recording.2024-02-09.154219.mp4

Android: mWeb Chrome

mweb.chrome.Recording.2024-02-08.170826.mp4

iOS: Native

ios.Recording.2024-02-10.121837.mp4

iOS: mWeb Safari

mweb.safari.Recording.2024-02-08.180423.mp4

mweb.safari.2.Recording.2024-02-08.180544.mp4

MacOS: Chrome / Safari

web.Recording.2024-02-08.163834.mp4

MacOS: Desktop

Desktop.Recording.2024-02-08.170222.mp4

…ents

…allScreen-props-in-components

…ouldShowSmallScreen-props-in-components

rayane-d · 2024-01-29T19:21:25Z

cc @getusha

melvin-bot · 2024-01-29T19:21:30Z

@blimpich Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rayane-d · 2024-01-29T19:24:38Z

@blimpich you can unassign yourself, this is part of #30528
@getusha will review

getusha · 2024-01-31T09:41:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-11.at.9.49.46.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-02-11.at.9.36.10.PM.mov

iOS: Native

Screen.Recording.2024-02-11.at.9.49.46.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-02-11.at.9.29.41.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-11.at.9.14.51.PM.mov

MacOS: Desktop

Screen.Recording.2024-02-11.at.10.01.08.PM.mov

getusha · 2024-01-31T09:42:04Z

@rayane-djouah lets complete Screenshots/Videos section.

rayane-d · 2024-02-05T10:57:49Z

Sorry for the delay, I will update today!

…allScreen-props-in-components

…ents

…ouldShowSmallScreen-props-in-components

Co-authored-by: Getabalew Tesfaye <75031127+getusha@users.noreply.github.com>

rayane-d · 2024-02-10T11:20:13Z

Updated

melvin-bot · 2024-02-11T19:02:43Z

🎯 @getusha, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #36308.

rayane-d · 2024-02-11T20:53:27Z

all yours @roryabraham

roryabraham · 2024-02-13T20:17:10Z

Sorry, was OOO and we have conflicts. I'll pre-review now in case there are any changes I want to request.

…allScreen-props-in-components

rayane-d · 2024-02-13T20:24:11Z

conflicts resolved

roryabraham

ok, this LGTM 👍🏼

roryabraham · 2024-02-13T20:37:47Z

-function SignInHeroImage(props) {
+function SignInHeroImage() {
    const styles = useThemeStyles();
+    const {isMediumScreenWidth} = useWindowDimensions();


NAB for this PR, but we should update useResponsiveLayout to export isMediumScreenWidth as well.

OSBotify · 2024-02-13T20:55:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-15T05:35:46Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.4.42-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-19T23:33:54Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.42-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

replace usages of shouldShowSmallScreen and isInModal props in compon…

e299ff5

…ents

rayane-d changed the title ~~Replace usages of is in modal and should show small screen props in components~~ Replace usages of isInModal and shouldShowSmallScreen props in components Jan 19, 2024

rayane-d mentioned this pull request Jan 19, 2024

[HOLD for payment 2024-10-30] [$1000] Create a useResponsiveLayout hook #30528

Closed

rayane-d added 7 commits January 27, 2024 20:46

Merge branch 'main' into replace-usages-of-isInModal-and-shouldShowSm…

518f501

…allScreen-props-in-components

Update BaseLoginForm.js

bfcc20f

fix lint errors

887e051

fix lint errors

b110b6d

Merge branch 'Expensify:main' into replace-usages-of-isInModal-and-sh…

578ad13

…ouldShowSmallScreen-props-in-components

fix error

d356b59

fix lint errors

15ef1d8

rayane-d marked this pull request as ready for review January 29, 2024 19:21

rayane-d requested a review from a team as a code owner January 29, 2024 19:21

melvin-bot Bot requested review from blimpich and removed request for a team January 29, 2024 19:21

blimpich removed their request for review January 29, 2024 23:42

getusha reviewed Feb 6, 2024

View reviewed changes

Comment thread src/pages/signin/SignInPageLayout/SignInPageContent.js Resolved

rayane-d added 5 commits February 8, 2024 14:15

Merge branch 'main' into replace-usages-of-isInModal-and-shouldShowSm…

05fc9ff

…allScreen-props-in-components

Replace usages of isInModal and shouldShowSmallScreen props in compon…

1c711fa

…ents

Merge branch 'Expensify:main' into replace-usages-of-isInModal-and-sh…

6be252d

…ouldShowSmallScreen-props-in-components

fix type error

1dd0407

fix type error

ec99856

getusha reviewed Feb 8, 2024

View reviewed changes

Comment thread src/hooks/useResponsiveLayout.ts Resolved

Comment thread src/pages/signin/SignInHeroImage.js Resolved

Update src/hooks/useResponsiveLayout.ts

c9bc960

Co-authored-by: Getabalew Tesfaye <75031127+getusha@users.noreply.github.com>

rayane-d requested a review from getusha February 10, 2024 11:19

getusha approved these changes Feb 11, 2024

View reviewed changes

melvin-bot Bot mentioned this pull request Feb 11, 2024

Payment issue for E/App PR#34837 #36308

Closed

Merge branch 'main' into replace-usages-of-isInModal-and-shouldShowSm…

7b913d7

…allScreen-props-in-components

roryabraham approved these changes Feb 13, 2024

View reviewed changes

roryabraham merged commit 148733c into Expensify:main Feb 13, 2024

rayane-d deleted the replace-usages-of-isInModal-and-shouldShowSmallScreen-props-in-components branch February 14, 2024 08:13

github-actions Bot mentioned this pull request Feb 15, 2024

Deploy Checklist: New Expensify 2024-02-15 #36558

Closed

73 tasks done

ZhenjaHorbach mentioned this pull request Feb 15, 2024

[$500] Login - Expensify logo is too close to the top of the screen #36575

Closed

2 of 6 tasks

rayane-d restored the replace-usages-of-isInModal-and-shouldShowSmallScreen-props-in-components branch February 15, 2024 18:58

Conversation

rayane-d commented Jan 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

rayane-d commented Jan 29, 2024

Uh oh!

melvin-bot Bot commented Jan 29, 2024

Uh oh!

rayane-d commented Jan 29, 2024

Uh oh!

getusha commented Jan 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

getusha commented Jan 31, 2024

Uh oh!

rayane-d commented Feb 5, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rayane-d commented Feb 10, 2024

Uh oh!

melvin-bot Bot commented Feb 11, 2024

Uh oh!

rayane-d commented Feb 11, 2024

Uh oh!

roryabraham commented Feb 13, 2024

Uh oh!

rayane-d commented Feb 13, 2024

Uh oh!

roryabraham left a comment

Choose a reason for hiding this comment

Uh oh!

roryabraham Feb 13, 2024

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Feb 13, 2024

Uh oh!

OSBotify commented Feb 15, 2024

Uh oh!

OSBotify commented Feb 19, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rayane-d commented Jan 19, 2024 •

edited

Loading

getusha commented Jan 31, 2024 •

edited

Loading