Repository navigation
[TS migration] Migrate 'Task' page to TypeScript - #35484
Conversation
9dcae8a to
2683540
Compare
2683540 to
9a0d540
Compare
rezkiy37
left a comment
There was a problem hiding this comment.
Left comments, after LGTM.
77a10c3 to
b0b0964
Compare
b0b0964 to
8344608
Compare
9326c1b to
6c38232
Compare
| const headerMessage = OptionsListUtils.getHeaderMessage(recentReports?.length + personalDetails?.length !== 0 || currentUserOption, Boolean(userToInvite), debouncedSearchValue); | ||
| const headerMessage = OptionsListUtils.getHeaderMessage( | ||
| recentReports?.length + personalDetails?.length !== 0 || Boolean(currentUserOption), | ||
| Boolean(userToInvite), |
There was a problem hiding this comment.
| Boolean(userToInvite), | |
| !!userToInvite, |
There was a problem hiding this comment.
I think Boolean is better since it is straight forward conversion
There was a problem hiding this comment.
The convention is to use !! across files, I agree with @kubabutkiewicz
There was a problem hiding this comment.
We don't have such a convention in the contributional guidelines.
I think using Boolean is better as you always understand what is going on and do not need to focus on the quantity of !
| const headerMessage = OptionsListUtils.getHeaderMessage(recentReports?.length + personalDetails?.length !== 0 || currentUserOption, Boolean(userToInvite), debouncedSearchValue); | ||
| const headerMessage = OptionsListUtils.getHeaderMessage( | ||
| recentReports?.length + personalDetails?.length !== 0 || Boolean(currentUserOption), | ||
| Boolean(userToInvite), |
There was a problem hiding this comment.
The convention is to use !! across files, I agree with @kubabutkiewicz
| type Task = { | ||
| /** Title of the Task */ | ||
| title: string; | ||
| title?: string; |
There was a problem hiding this comment.
Why was this changed?
There was a problem hiding this comment.
We can change the description without the title
b5268ef to
eb5cf4b
Compare
eb5cf4b to
dd2e3bf
Compare
|
@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Assigning @allroundexperts for C+ review |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-03-07.at.1.21.01.AM.movAndroid: mWeb ChromeScreen.Recording.2024-03-07.at.1.19.52.AM.moviOS: NativeScreen.Recording.2024-03-07.at.1.19.02.AM.moviOS: mWeb SafariScreen.Recording.2024-03-07.at.1.17.45.AM.movMacOS: Chrome / SafariScreen.Recording.2024-03-07.at.1.12.46.AM.movMacOS: DesktopScreen.Recording.2024-03-07.at.1.15.38.AM.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.4.49-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.50-5 🚀
|
Details
Fixed Issues
$#25212
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android-native-converted.webm
Android: mWeb Chrome
aandroid-web-converted.webm
iOS: Native
ios-mobile-converted.mp4
iOS: mWeb Safari
ios-web-converted.mp4
MacOS: Chrome / Safari
desktop-web-converted.mov
MacOS: Desktop
desktop-native-converted.mov