Repository navigation
Disable locale picker while signing in #35794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
51af936
disable locale picker while signing in
tienifr d31d5dc
set isDisabled
tienifr 2a6819a
Merge branch 'main' of https://github.com/tienifr/App into fix/34645
tienifr 76a2811
create util function
tienifr d1427e0
Merge branch 'main' into fix/34645
tienifr b0ff3ca
Move to AccountUtils
tienifr 27f4dd0
fix lint
tienifr 601e20f
Merge branch 'main' of https://github.com/tienifr/App into fix/34645
tienifr 9eee9aa
Merge branch 'main' into fix/34645
tienifr 36b43f1
fix perf-test
tienifr 511832b
fix lint
tienifr a64a4da
fix typecheck
tienifr 7ebc725
Merge branch 'main' of https://github.com/tienifr/App into fix/34645
tienifr f239bce
Merge branch 'main' of https://github.com/tienifr/App into fix/34645
tienifr ee7f4d9
revert: fix perf-test
tienifr 4953774
fix perf-test by modifying test
tienifr 796288f
fix typecheck
tienifr f126673
use util function
tienifr 4c0f478
Merge branch 'main' of https://github.com/tienifr/App into fix/34645
tienifr 2fe5e7a
use OnyxEntry type
tienifr 886123a
conver undefined to boolean
tienifr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| import type {OnyxEntry} from 'react-native-onyx'; | ||
| import CONST from '@src/CONST'; | ||
| import type {Account} from '@src/types/onyx'; | ||
|
|
||
| const isValidateCodeFormSubmitting = (account: OnyxEntry<Account>) => | ||
| !!account?.isLoading && account.loadingForm === (account.requiresTwoFactorAuth ? CONST.FORMS.VALIDATE_TFA_CODE_FORM : CONST.FORMS.VALIDATE_CODE_FORM); | ||
|
|
||
| export default {isValidateCodeFormSubmitting}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -750,7 +750,7 @@ const styles = (theme: ThemeColors) => | |
| height: 140, | ||
| }, | ||
|
|
||
| pickerSmall: (backgroundColor = theme.highlightBG) => | ||
| pickerSmall: (disabled = false, backgroundColor = theme.highlightBG) => | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do we need this change?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Without this the cursor would still show pointer though the picker was disabled. |
||
| ({ | ||
| inputIOS: { | ||
| fontFamily: FontUtils.fontFamily.platform.EXP_NEUE, | ||
|
|
@@ -792,7 +792,7 @@ const styles = (theme: ThemeColors) => | |
| height: 26, | ||
| opacity: 1, | ||
| backgroundColor, | ||
| ...cursor.cursorPointer, | ||
| ...(disabled ? cursor.cursorDisabled : cursor.cursorPointer), | ||
| }, | ||
| inputAndroid: { | ||
| fontFamily: FontUtils.fontFamily.platform.EXP_NEUE, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite understanding why these two props are necessary. Can they just be derived from the
isDisabledprop?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldShowOnlyTextWhenDisabled, the locales would only show their key name (enores). This is for use in pages likeCompanyStep.shouldAllowDisabledStyle.