Skip to content

Fix bank account shows not found when trying to pay with business bank account #35981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cead22 merged 2 commits into from
Feb 19, 2024
Merged

Fix bank account shows not found when trying to pay with business bank account #35981

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a13a56
don't early return if email is empty
bernhardoj Feb 7, 2024
5a11e45
Merge branch 'main' into fix/35366-ba-page-not-open
bernhardoj Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libs/actions/Policy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1562,7 +1562,7 @@ function createWorkspaceFromIOUPayment(iouReport: Report | EmptyObject): string
const policyID = generatePolicyID();
const workspaceName = generateDefaultWorkspaceName(sessionEmail);
const employeeAccountID = iouReport.ownerAccountID;
const employeeEmail = iouReport.ownerEmail;
const employeeEmail = iouReport.ownerEmail ?? '';

@shubham1206agra shubham1206agra Feb 8, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const employeeEmail = iouReport.ownerEmail ?? '';
const employeeEmail = allPersonalDetails?.[employeeAccountID?.toString() ?? '']?.login;

Maybe use this instead.

@bernhardoj bernhardoj Feb 8, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think that we don't need to have an email here, we can just put it empty and it will still work
employeeEmail = ''
but I guess it would look weird. But instead of retrieving the email from the personal detail, I just use null-coalescing to keep it simple.

const {customUnits, customUnitID, customUnitRateID} = buildOptimisticCustomUnits();
const oldPersonalPolicyID = iouReport.policyID;
const iouReportID = iouReport.reportID;
Expand All @@ -1582,7 +1582,7 @@ function createWorkspaceFromIOUPayment(iouReport: Report | EmptyObject): string
expenseCreatedReportActionID: workspaceChatCreatedReportActionID,
} = ReportUtils.buildOptimisticWorkspaceChats(policyID, workspaceName);

if (!employeeAccountID || !employeeEmail) {
if (!employeeAccountID) {
return;
}

Expand Down