Repository navigation
[No QA] [TS migration] Migrate 'installApp.js' test to TypeScript #37004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pecanoro
merged 7 commits into
Expensify:main
from
VickyStash:ts-migration/installApp-test
Mar 4, 2024
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c71004d
[TS migration] Migrate 'installApp.js' test
VickyStash 0101e8e
Minor code improvement
VickyStash 04ebc12
Merge branch 'main' into ts-migration/installApp-test
VickyStash 94583c9
Replace module.exports with export
VickyStash 99dff5f
Merge branch 'main' into ts-migration/installApp-test
VickyStash 919ccd0
Improve return type
VickyStash 77b486a
Merge branch 'main' into ts-migration/installApp-test
VickyStash File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import type {ExecException} from 'child_process'; | ||
| import execAsync from './execAsync'; | ||
| import type {PromiseWithAbort} from './execAsync'; | ||
| import * as Logger from './logger'; | ||
|
|
||
| /** | ||
| * Installs the app on the currently connected device for the given platform. | ||
| * It removes the app first if it already exists, so it's a clean installation. | ||
| */ | ||
| export default function (packageName: string, path: string, platform = 'android'): PromiseWithAbort { | ||
| if (platform !== 'android') { | ||
| throw new Error(`installApp() missing implementation for platform: ${platform}`); | ||
| } | ||
|
|
||
| // Uninstall first, then install | ||
| return ( | ||
| execAsync(`adb uninstall ${packageName}`) | ||
| .catch((error: ExecException) => { | ||
| // Ignore errors | ||
| Logger.warn('Failed to uninstall app:', error); | ||
| }) | ||
| // eslint-disable-next-line @typescript-eslint/no-misused-promises | ||
| .finally(() => execAsync(`adb install ${path}`)) | ||
| ); | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can remove this comment by doing this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabioh8010 I've tried it initially, but this way the test hasn't launched the app properly for me, so I decided to keep the logic