Skip to content

[No QA] Fix failing TS on main #37171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danieldoglas merged 2 commits into from
Feb 24, 2024
Merged

[No QA] Fix failing TS on main #37171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
182e645
Fix failing TS on main
roryabraham Feb 24, 2024
8ab8000
Fix typo
roryabraham Feb 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/e2e/utils/execAsync.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,5 @@ export default (command: string, env: NodeJS.ProcessEnv = {}): PromiseWithAbort

return promise;
};

export type {PromiseWithAbort};
3 changes: 2 additions & 1 deletion tests/e2e/utils/killApp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import config from '../config';
import execAsync from './execAsync';
import type {PromiseWithAbort} from './execAsync';

const killApp = function (platform = 'android', packageName = config.MAIN_APP_PACKAGE): Promise<void> {
const killApp = function (platform = 'android', packageName = config.MAIN_APP_PACKAGE): PromiseWithAbort {
if (platform !== 'android') {
throw new Error(`killApp() missing implementation for platform: ${platform}`);
}
Expand Down