Repository navigation
[TS migration] Migrate 'Tooltip.stories.js', 'TextInput.stories.js', 'Picker.stories.js', 'MagicCodeInput.stories.js' and 'InlineSystemMessage.stories.js' stories - #37753
Conversation
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
|
@mountiny During the testing of this PR I've noticed an existing bug for Steps to reproduce:
Actual result: Expected result: TooltipBug.mp4 |
|
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
mountiny
left a comment
There was a problem hiding this comment.
Changes look good to me
|
@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
the tests were passing |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.50-5 🚀
|
Details
[TS migration] Migrate 'Tooltip.stories.js', 'TextInput.stories.js', 'Picker.stories.js', 'MagicCodeInput.stories.js' and 'InlineSystemMessage.stories.js' stories
Fixed Issues
$ #25335
$ #25336
$ #25337
$ #25338
$ #25339
PROPOSAL: N/A
Tests
TextInputstories and look through all of them. Make sure they look and work the same way as before. Note: there is an error for Prefixed Input, but it looks like it's expected.MagicCodeInputstories. Make sure they both looks and work the same way as before.InlineSystemMessagestory. Make sure the message looks ok.Pickerstories and look through all of them. Make sure they look and work the same way as before.Tooltipstories. Make sure they both looks and work the same way as before.Offline tests
N/A
QA Steps
Same as in the Tests section.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Tooltip
Tooltip.mp4
TextInput
TextInput1.mp4
Picker
Picker.mp4
MagicCodeInput
MagicCodeInput.mp4
InlineSystemMessage