Repository navigation
[No QA] Fix: Expensify engineer is not tagged and assigned in Deploy Checklist to complete the QA for PRs with Internal QA. - #37933
Conversation
…t to complete the QA for PRs with Internal QA.
…-tagged-and-assigned-in-Deploy-Checklist-to-complete-the-QA-for-PRs-with-Internal-QA
|
@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
cc @roryabraham |
mkhutornyi
left a comment
There was a problem hiding this comment.
Looks like this doesn't require C+ review.
Just approving to assign Rory
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
This change is causing a failure for the Staging checklist https://github.com/Expensify/App/actions/runs/8231107620/job/22505767275 |
|
We hit some error which is not clear to me now when creating the checklist and then the destructuring did not work App/.github/libs/GithubUtils.js Line 333 in 2c5d6c5 |
|
checklist built successfully after revert #38037 something must be off here |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.50-5 🚀
|

Details
Fixed Issues
$ #37691
PROPOSAL: #37691 (comment)
Tests
N/A
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
N/A
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop