Repository navigation
Enable creating P2P distance requests - #37947
Conversation
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@shubham1206agra C+ can't really test this yet so I'm going to ask an internal engineer to review and test. |
| transactionThreadReportID: string; | ||
| createdReportActionIDForThread: string; | ||
| payerEmail: string; | ||
| customUnitRateID?: string; |
There was a problem hiding this comment.
This is not used, did you include it now so we know it's here when we need it?
There was a problem hiding this comment.
Yeah I could have left it out, but might as well get ready for it to be added soon.
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
@neil-marcellini could you help us with this step? Is this internal testing part?
|
|
Sorry @m-natarajan I should have made it more clear that there's No QA needed. Updating the description to say that now. |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.50-5 🚀
|
Details
Fixed Issues
$ #36986
PROPOSAL: N/A
Tests
Internal only until the backend changes are deployed to staging.
Checkout branches
neil-p2p-distancein Web-E and Auth. Build and restart Auth.Transaction violations will show unless you checkout the branch
neil-p2p-distance-violations, which is branched offneil-p2p-distance.We don't need to hold on any of the PRs above because we have an internal only beta preventing creating P2P distance requests on the frontend.
Make sure you run
script/bwm.shfor Pusher to work.A: New user
B: Existing user
C: Workspace request
D: Workspace request without backend P2P changes
Offline tests
QA Steps
No QA
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
I only tested on Web because the changes here are extremely simple and are platform independent.
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
A
A.mov
B
B.mov
C
C.mov
D
D.mov
MacOS: Desktop