Repository navigation
Fix app crash when navigating to IOU when created offline - #37985
Merged
Merged
Conversation
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeScreen.Recording.2024-03-08.at.10.03.46.PM.moviOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2024-03-08.at.10.01.50.PM.movMacOS: Desktop |
luacmartins
approved these changes
Mar 8, 2024
OSBotify
pushed a commit
that referenced
this pull request
Mar 8, 2024
Fix app crash when navigating to IOU when created offline (cherry picked from commit 2cf6077)
43 tasks done
Contributor
|
🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 1.4.49-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Contributor
|
🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 1.4.49-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
3 of 6 tasks
Contributor
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.50-5 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #37965
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop