Repository navigation
[CP Staging] Avoid using useCallback in trackVerticalScrolling - #38091
Conversation
|
@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid.movAndroid: mWeb ChromemWeb-chrome.moviOS: NativeiOS.moviOS: mWeb Safarimweb-safari-1.movMacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
|
@marcochavezf wanna request the CP? |
|
Yup, requested here https://expensify.enterprise.slack.com/archives/C07J32337/p1710194304539379 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[CP Staging] Avoid using useCallback in trackVerticalScrolling (cherry picked from commit b8f16ba)
…ing-38091-1 🍒 Cherry pick PR #38091 to staging 🍒
|
🚀 Deployed to staging by https://github.com/amyevans in version: 1.4.50-5 🚀
|
|
This is fixed in staging |
|
🚀 Deployed to staging by https://github.com/amyevans in version: 1.4.50-5 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.50-5 🚀
|
Details
This PR removes the remaining changes to
ReportActionListintroduced here and reverted here.Fixed Issues
$ #38062
Tests
Screen.Recording.2024-03-11.at.3.00.15.p.m.mov
Offline tests
N/A
QA Steps
Same as test steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop