[CP Staging] Fix: iOS - Thread - Unable to send a message after returning from thread - ParentNavigationSubtitle - Update navigation method to go back instead of navigate by rayane-d · Pull Request #40315 · Expensify/App

rayane-d · 2024-04-16T21:20:12Z

cc @rushatgabhane @marcaaron

Details

Fixed Issues

$ #40057
PROPOSAL: N/A

Tests

Go to chat
Send a message
Send a reply to the message in thread
Click on the header subtitle
Send a message
Note that user can send a message
Swipe right twice to return to the main chat but without highlight on the parent message
Send a message
Verify that the user is be able to send a message

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Recording.2024-04-16.221248.mp4

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…ead - ParentNavigationSubtitle - Update navigation method to go back instead of navigate

melvin-bot · 2024-04-16T21:20:17Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rushatgabhane

Bug: if you tap profile photo before going back the user can’t send a message

steps:

Go to a DM
Send a message
Create a thread and reply to the message in thread
Tap on profile photo to open the user’s profile details
Tap back
Click on header subtitle
Go back. You’re not at root level thread
Try to send a message. But you can’t

Screen.Recording.2024-04-17.at.02.56.39.mov

rushatgabhane

@rayane-djouah the workaround isn't working. The bug (with navigate to profile) is still reproducible

Screen.Recording.2024-04-17.at.15.22.17.mov

rayane-d · 2024-04-17T10:11:49Z

@rushatgabhane, I'm unable to reproduce with the same steps. Am I missing something?

Recording.2024-04-17.111039.mp4

rushatgabhane · 2024-04-17T10:20:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-17.at.16.03.18.mov

Android: mWeb Chrome

Uploading Screen Recording 2024-04-17 at 16.07.24.mov…

iOS: Native

Screen.Recording.2024-04-17.at.15.49.11.mov

Screen.Recording.2024-04-17.at.15.55.04.mov

iOS: mWeb Safari

Screen.Recording.2024-04-17.at.16.02.14.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-17.at.15.58.16.mov

MacOS: Desktop

rushatgabhane

LGTM! cc: @marcaaron @mountiny

mountiny

Thanks! lets still dig into this one to figure out the root cause as this feels like a workaround

OSBotify · 2024-04-17T10:47:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…cestry-to-deep-link-back-to-the-original-comment [CP Staging] Fix: iOS - Thread - Unable to send a message after returning from thread - ParentNavigationSubtitle - Update navigation method to go back instead of navigate (cherry picked from commit 5c43aa5)

OSBotify · 2024-04-17T11:32:34Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.4.62-14 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-04-18T04:35:09Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.62-17 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

allgandalf · 2025-03-17T08:18:32Z

+                // Pop the thread report screen before navigating to the chat report.
+                Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(parentReportID));
+                if (isVisibleAction && !isOffline) {
+                    // Pop the chat report screen before navigating to the linked report action.
+                    Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(parentReportID, parentReportActionID));


This change was not implemented correctly, it caused #54574, but @rayane-d helped us a lot to test the changes thoroughly by giving us a complete list of tests #54574 (comment)

Fix: iOS - Thread - Unable to send a message after returning from thr…

12259a2

…ead - ParentNavigationSubtitle - Update navigation method to go back instead of navigate

rayane-d requested a review from a team as a code owner April 16, 2024 21:20

melvin-bot Bot requested review from hungvu193 and removed request for a team April 16, 2024 21:20

rushatgabhane suggested changes Apr 16, 2024

View reviewed changes

Fix threads navigation

22c1e57

rayane-d requested a review from rushatgabhane April 17, 2024 08:08

rushatgabhane reviewed Apr 17, 2024

View reviewed changes

rushatgabhane approved these changes Apr 17, 2024

View reviewed changes

melvin-bot Bot requested a review from marcaaron April 17, 2024 10:34

mountiny assigned rayane-d Apr 17, 2024

mountiny approved these changes Apr 17, 2024

View reviewed changes

mountiny merged commit 5c43aa5 into Expensify:main Apr 17, 2024

github-actions Bot mentioned this pull request Apr 17, 2024

Deploy Checklist: New Expensify 2024-04-10 #40026

Closed

melvin-bot Bot mentioned this pull request Apr 18, 2024

[HOLD for payment 2024-04-25] iOS - Thread - Unable to send a message after returning from thread #40057

Closed

1 of 6 tasks

FitseTLT mentioned this pull request Apr 23, 2024

[$500] Chat - Inconsistency in displaying unread green line when navigating from thread #31026

Closed

6 tasks done

s77rt mentioned this pull request May 5, 2024

[Awaiting Payment 30th May] [Search v1] Chat - "From" link in IOU report details page navigates to the main chat twice #41198

Closed

4 of 6 tasks

daledah mentioned this pull request Feb 3, 2025

[Due for payment 2025-03-13] [$500] Web - On leaving thread & tapping back, user directed to previous visited page #54574

Closed

1 of 8 tasks

allgandalf reviewed Mar 17, 2025

View reviewed changes

Navigation Menu

Repository navigation

[CP Staging] Fix: iOS - Thread - Unable to send a message after returning from thread - ParentNavigationSubtitle - Update navigation method to go back instead of navigate - #40315

rayane-d commented Apr 16, 2024 •

edited

Loading

Uh oh!

melvin-bot Bot commented Apr 16, 2024

Uh oh!

rushatgabhane left a comment •

edited

Loading

Uh oh!

rushatgabhane left a comment

Uh oh!

rayane-d commented Apr 17, 2024

Uh oh!

rushatgabhane commented Apr 17, 2024 •

edited

Loading

Uh oh!

rushatgabhane left a comment •

edited

Loading

Uh oh!

mountiny left a comment

Uh oh!

OSBotify commented Apr 17, 2024

Uh oh!

OSBotify commented Apr 17, 2024

Uh oh!

OSBotify commented Apr 18, 2024

Uh oh!

allgandalf Mar 17, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

rayane-d commented Apr 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 16, 2024

Uh oh!

rushatgabhane left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rushatgabhane left a comment

Choose a reason for hiding this comment

Uh oh!

rayane-d commented Apr 17, 2024

Uh oh!

rushatgabhane commented Apr 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

rushatgabhane left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 17, 2024

Uh oh!

OSBotify commented Apr 17, 2024

Uh oh!

OSBotify commented Apr 18, 2024

Uh oh!

allgandalf Mar 17, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rayane-d commented Apr 16, 2024 •

edited

Loading

rushatgabhane left a comment •

edited

Loading

rushatgabhane commented Apr 17, 2024 •

edited

Loading

rushatgabhane left a comment •

edited

Loading