Skip to content

[HOLD] Apply changes from main directly to staging - #4083

Closed
tgolen wants to merge 1 commit into
stagingfrom
tgolen-fix-scroll
Closed

tgolen wants to merge 1 commit into
stagingfrom
tgolen-fix-scroll

Conversation

@tgolen

@tgolen tgolen commented Jul 15, 2021

Copy link
Copy Markdown
Contributor

Details

It seems like the last staging deploy had a glitch in it and some of these changes weren't applied. All I did was copy the contents of WorkspaceInvitePage.js from main.

Fixed Issues

$ #4060

Tests

  1. Go to invite someone to a workspace
  2. Verify the form fields aren't duplicated

QA Steps

Same as above

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

Desktop

iOS

Android

@tgolen
tgolen requested a review from roryabraham July 15, 2021 17:56
@tgolen tgolen self-assigned this Jul 15, 2021
@tgolen
tgolen requested a review from a team as a code owner July 15, 2021 17:56
@MelvinBot
MelvinBot requested review from Luke9389 and removed request for a team July 15, 2021 17:57
@tgolen

tgolen commented Jul 15, 2021

Copy link
Copy Markdown
Contributor Author

This PR is targetted specifically to the staging branch.

@tgolen tgolen changed the title Apply changes from main directly to staging [HOLD] Apply changes from main directly to staging Jul 15, 2021
@tgolen

tgolen commented Jul 15, 2021

Copy link
Copy Markdown
Contributor Author

Putting a hold on this until we decide exactly how we want to fix this.

@roryabraham

Copy link
Copy Markdown
Contributor

Hmmm I don't think we should merge this ... I am not 100% sure but I'm worried that there might be some unexpected side-effects that could break the CD. Let's start by just running a normal staging deploy (i.e: deploy main branch to staging), and see if that resolves this, then go from there. See this comment.

@tgolen

tgolen commented Jul 15, 2021

Copy link
Copy Markdown
Contributor Author

Sounds good. I'll just close this for now.

@tgolen tgolen closed this Jul 15, 2021
@coleaeason
coleaeason deleted the tgolen-fix-scroll branch May 19, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants