Skip to content

Navigate to accounting page #41428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hayata-suenaga wants to merge 2 commits into from
Closed

Navigate to accounting page #41428

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41d105b
feat: navigate to accounting page
May 1, 2024
ff02b21
Merge branch 'main' into hayata-navigate-to-accounting-page-on-enable…
May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/libs/actions/Policy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3987,6 +3987,9 @@ function enablePolicyConnections(policyID: string, enabled: boolean) {
const parameters: EnablePolicyConnectionsParams = {policyID, enabled};

API.write(WRITE_COMMANDS.ENABLE_POLICY_CONNECTIONS, parameters, onyxData);
if (enabled) {
navigateWhenEnableFeature(policyID, ROUTES.POLICY_ACCOUNTING.getRoute(policyID));
}
Comment on lines +3990 to +3992

@allroundexperts allroundexperts May 1, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hayata-suenaga Aren't we not navigating to the feature page for other features? I remember removing this.

@hayata-suenaga hayata-suenaga May 1, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah really? can you link a PR that will be removing the navigation? 🙇 😮

@allroundexperts allroundexperts May 1, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the PR: #40369 and this is the discussion from the design team.

@hayata-suenaga hayata-suenaga May 2, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like your PR was reverted here, @allroundexperts

do you know why that was reverted?

@allroundexperts allroundexperts May 5, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It caused an issue on iOS. I'll raise the PR again with a fix.

@hayata-suenaga hayata-suenaga May 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me know once you raised the PR so that I can see what change you're making 😄

@trjExpensify trjExpensify May 7, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How you getting on here @allroundexperts?

@hayata-suenaga hayata-suenaga May 13, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@allroundexperts, you can handle this in your PR. I'm closing this

}

function enablePolicyDistanceRates(policyID: string, enabled: boolean) {
Expand Down