fix(AddressPage): country reverts to previous one after selecting state by zfurtak · Pull Request #45394 · Expensify/App

zfurtak · 2024-07-15T10:17:29Z

Details

Fixed Issues

$ #44957
PROPOSAL:

Tests

Go to Account settings > Profile > Address
Click Country
Select a country (not US)
Enter a US address and select any US address (eg. golden gate bridge)
Click State
Select a different state
Verify that: The country field will not revert to the previous selection after selecting a new state (it's still US)

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Go to Account settings > Profile > Address
Click Country
Select a country (not US)
Enter a US address and select any US address (eg. golden gate bridge)
Click State
Select a different state
Verify that: The country field will not revert to the previous selection after selecting a new state (it's still US)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

Screen.Recording.2024-07-15.at.16.10.49.mov

MacOS: Chrome / Safari

Screen.Recording.2024-07-15.at.14.23.41.mov

MacOS: Desktop

desktop.mov

adamgrzybowski · 2024-07-15T13:21:41Z

LGTM 🎸

melvin-bot · 2024-07-15T13:28:43Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

s77rt · 2024-07-15T15:49:10Z

-    if (currentRoute?.path) {
-        return currentRoute.path;
-    }


Is the currentRoute.path incorrect here? Seems that the bug should be fixed in navigationRef.current.getCurrentRoute()

Indeed navigationRef.current.getCurrentRoute() returns wrong path, it's connected to the fact that when choosing whole address (in addressLine1) we change values of the fields but we don't navigate, so the path is not changing.
However the if condition was added to fix a navigation issue which no longer occurs (even without it)

Ah I see. Although getPathFromState still suffers from the encoding issue it's seems okay to use for now.

s77rt

@hoangzinh Can you please complete the checklist?

hoangzinh · 2024-07-17T01:59:21Z

@s77rt Yep, actually I'm verifying the solution carefully.

hoangzinh · 2024-07-17T16:17:52Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-17.at.23.15.29.android.mov

Android: mWeb Chrome

Screen.Recording.2024-07-17.at.23.17.14.android.chrome.mov

iOS: Native

Screen.Recording.2024-07-17.at.23.12.39.ios.mov

iOS: mWeb Safari

Screen.Recording.2024-07-17.at.23.14.47.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2024-07-17.at.23.05.08.web.mov

MacOS: Desktop

Screen.Recording.2024-07-17.at.23.05.51.desktop.mov

hoangzinh

Looks good. Tested well

hoangzinh · 2024-07-17T16:29:41Z

@mountiny all yours!

mountiny

Thanks for the fix and apologies for taking longer with the review, been ooo

OSBotify · 2024-07-19T20:13:42Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.10-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-22T13:35:58Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.10-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-23T08:03:40Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.10-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-07-25T03:14:54Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.11-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix selecting state on AdressPage

ca0af97

zfurtak changed the title ~~fix: fix selecting state on AddressPage~~ fix(AddressPage): country reverts to previous one after selecting state Jul 15, 2024

blazejkustra approved these changes Jul 15, 2024

View reviewed changes

adamgrzybowski approved these changes Jul 15, 2024

View reviewed changes

zfurtak mentioned this pull request Jul 15, 2024

[$250] Address - Country field reverts to the previous selection after selecting a new state #44957

Closed

6 tasks done

zfurtak marked this pull request as ready for review July 15, 2024 13:28

zfurtak requested a review from a team as a code owner July 15, 2024 13:28

melvin-bot Bot requested review from hoangzinh and removed request for a team July 15, 2024 13:28

s77rt suggested changes Jul 15, 2024

View reviewed changes

s77rt approved these changes Jul 16, 2024

View reviewed changes

melvin-bot Bot requested a review from mountiny July 16, 2024 16:43

s77rt mentioned this pull request Jul 16, 2024

fix: navigate link when state selector #45153

Closed

50 tasks done

hoangzinh approved these changes Jul 17, 2024

View reviewed changes

mountiny assigned zfurtak Jul 19, 2024

mountiny approved these changes Jul 19, 2024

View reviewed changes

mountiny merged commit 0f48485 into Expensify:main Jul 19, 2024

github-actions Bot mentioned this pull request Jul 19, 2024

Deploy Checklist: New Expensify 2024-07-19 #45794

Closed

zfurtak deleted the @zfurtak/fix-address-page branch April 4, 2025 13:08

Conversation

zfurtak commented Jul 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

adamgrzybowski commented Jul 15, 2024

Uh oh!

melvin-bot Bot commented Jul 15, 2024

Uh oh!

s77rt Jul 15, 2024

Choose a reason for hiding this comment

Uh oh!

zfurtak Jul 16, 2024

Choose a reason for hiding this comment

Uh oh!

s77rt Jul 16, 2024

Choose a reason for hiding this comment

Uh oh!

s77rt left a comment

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented Jul 17, 2024

Uh oh!

hoangzinh commented Jul 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented Jul 17, 2024

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jul 19, 2024

Uh oh!

OSBotify commented Jul 22, 2024

Uh oh!

OSBotify commented Jul 23, 2024

Uh oh!

OSBotify commented Jul 25, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

zfurtak commented Jul 15, 2024 •

edited

Loading

hoangzinh commented Jul 17, 2024 •

edited

Loading