Repository navigation
LHN - RBR appears on the wrong workspace chat for an error occurring on another workspace - #49202
Conversation
…error occurring on another workspace Expensify#47874
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
@SIMalik, can you please upload the videos for all other platforms? We need to do this to ensure all platforms pass, and I will also upload my own tests for all platforms again when I fill the check list later. :) |
|
Hi @ntdiary, Thank you for reviewing my PR. I wanted to ask for some guidance on how to test the changes across all six platforms (Android Native, Android mWeb Chrome, iOS Native, iOS mWeb Safari, MacOS Chrome/Safari, and MacOS Desktop). Currently, I'm using Linux for development, and as this is my first PR, I'm not entirely sure how to test on all these platforms. Could you please advise on the best approach for this? Any help or resources you can provide would be greatly appreciated. Thank you! |
|
https://github.com/Expensify/App/blob/main/contributingGuides/TESTING_MACOS_AND_IOS.md |
@ntdiary Hi |
Reviewer Checklist
Screenshots/Videos |
| const reportErrors = report?.errors ?? {}; | ||
| const reportErrorFields = report?.errorFields ?? {}; | ||
| const reportActionsArray = Object.values(reportActions ?? {}); | ||
| const reportActionsArray = Object.values(reportActions ?? {}).filter(action => !ReportActionUtils.isDeletedAction(action)); |
There was a problem hiding this comment.
| const reportActionsArray = Object.values(reportActions ?? {}).filter(action => !ReportActionUtils.isDeletedAction(action)); | |
| const reportActionsArray = Object.values(reportActions ?? {}).filter((action) => !ReportActionUtils.isDeletedAction(action)); |
tiny lint issue. :)
There was a problem hiding this comment.
@SIMalik, can you please fix this tiny issue? I will fill the check list soon. :)
|
Addtionally, @SIMalik, did you encounter any difficulties while setting up the environment? :) |
|
@ntdiary |
|
@SIMalik, Have you run |
|
@ntdiary |
|
@SIMalik, can you please provide a clearer screenshot of the emulator error? I couldn't make out the error message on it. 😂 Also, if you can test the Android mWeb using As for security error, it’s usually due to not having the correct local HTTPS setup. BTW, we have a time zone difference, so my responses may not be timely. :) |
|
@ntdiary Could you please confirm if this meets the requirements? |
|
@SIMalik, LGTM! And if the video is too large, you can also upload screenshots like I did. 😄 |
|
@SIMalik, any updates for the other platforms? :) |
|
@ntdiary |
|
Hi @ntdiary, I initially installed macOS 10.15 Catalina, but I encountered several unsupported command issues, which affected its performance. Realizing it was an outdated version, I decided to remove it. Currently, I am in the process of installing macOS 15 Sequoia. Since this is my first time installing macOS, it’s taking some time, but I'm making progress and am not stuck. Thank you for your understanding! |
|
Hi @ntdiary MacOS: Chrome / Safari Working on other platforms. |
neil-marcellini
left a comment
There was a problem hiding this comment.
Requesting changes to fix the failing tests
|
You're absolutely right; I’m currently working on addressing the failing tests and will make the necessary adjustments. |
|
App/tests/unit/DebugUtilsTest.ts Lines 1310 to 1317 in abdfb72 The mock So we need to add the As for the ESLint and performance errors, based on the logs, they don't seem related to this PR. Perhaps we can try running the tests again after merging the latest |
Test Suites: 1 passed, 1 total |
|
Hi, @neil-marcellini, can you please rerun the tests? :) |
neil-marcellini
left a comment
There was a problem hiding this comment.
Looks good thanks. The performance check is failing due to some weird merge conflict issue. I'm re-running it, but if it fails again we'll need to investigate more deeply.
|
@SIMalik I would try merging main into this PR. This merge is failing. |
I went ahead and merged the main branch into the feature branch (issue-47874). The merge completed successfully with no conflicts. I have also pushed the updated branch. The latest commit hash is 30f43f2, and the branch is now fully up to date with main. Please let me know if there’s anything else I should address or if any further steps are needed on this. Thanks, |
|
@SIMalik looks like there are conflicts again |
|
Conflicts removed. |
|
@SIMalik, It looks like a swiftUI compatibility prolem, would it be possible for you to upgrade to the new version? Here are the version compatibility requirements: Addtionally, @neil-marcellini, can you please run tests again when you have time? :) |
|
The changed files check is failing but none of those files were changed in this PR, so they should be handled elsewhere. |
|
@neil-marcellini looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.51-1 🚀
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.51-4 🚀
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.51-4 🚀
|


















Details
Fixed Issues
$ #47874
PROPOSAL: #47874 (comment)
Tests
Offline tests
NA
QA Steps
Same as Tests above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
47874-NoErrorShown-2.mp4
Android: Native
Android: mWeb Chrome
Video
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop