fix: Profile - No error after uploading corrupted jpg for avatar, console error shows up. by Krishna2323 · Pull Request #49203 · Expensify/App

Krishna2323 · 2024-09-14T11:48:02Z

Details

Fixed Issues

$ #48707
PROPOSAL: #48707 (comment)

Tests

Go to Account settings > Profile
Click on the avatar > Upload photo
Upload a corrupted jpg file (attached below)
Verify error message is shown below the Avatar

Verify that no errors appear in the JS console

Offline tests

Go to Account settings > Profile
Click on the avatar > Upload photo
Upload a corrupted jpg file (attached below)
Verify error message is shown below the Avatar

QA Steps

Go to Account settings > Profile
Click on the avatar > Upload photo
Upload a corrupted jpg file (attached below)
Verify error message is shown below the Avatar

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

…sole error shows up. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot · 2024-09-14T11:48:07Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2024-09-14T13:52:10Z

+                            });
+                    });
+                return;
+            }


@Ollyws, we have to skip corrupt image validation in AttachmentPicker because, on native devices, we were showing an alert modal if the image was corrupt, which we don't need when using AttachmentPicker inside AvatarWithImagePicker because we already perform validation in the AvatarWithImagePicker component.

Hmm...would it make more sense to do the image validation in AttachmentPicker on both platforms?

I tried, but I wasn't able to get it working. I'll try again today or tomorrow.

@Ollyws, I tried and we can show the validation modal in AttachmentPicker for web, but I don't think it's worth it since the native validation shows only the default alert and in this case we should show the our custom modal. We can simply skip the validation in native file. WDYT?

@Ollyws, friendly bump to check the comment above.

We can simply skip the validation in native file

You mean just leave the changes as they are?

Ok it's not a huge issue so I think it's fine as is.

Ollyws · 2024-09-16T20:41:03Z

Will get to this one tomorrow.

Ollyws · 2024-09-17T07:51:55Z

-            .then(() => resolve())
-            .catch(() => reject(new Error('Error reading file: The file is corrupted')));
+            .then((size) => {
+                if (size.height <= 0 || size.width <= 0) {


Why's this change necessary?

On native, when an image is corrupted, ImageSize.getSize does not throw an error but returns an image with a width and height of -1.

The same method is used here:

App/src/components/AttachmentPicker/index.native.tsx

Lines 272 to 280 in 37bf6b2

const validateAndCompleteAttachmentSelection = useCallback(

(fileData: FileResponse) => {

// Check if the file dimensions indicate corruption

// The width/height for a corrupted file is -1 on android native and 0 on ios native

// We must check only numeric values because the width/height can be undefined for non-image files

if ((typeof fileData.width === 'number' && fileData.width <= 0) || (typeof fileData.height === 'number' && fileData.height <= 0)) {

showImageCorruptionAlert();

return Promise.resolve();

}

Krishna2323 · 2024-09-23T09:41:08Z

Sorry for delay, I will work on this today.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Ollyws · 2024-09-27T13:11:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Ollyws

LGTM.

srikarparsi

Just one change from me

srikarparsi · 2024-09-29T19:43:08Z

-                        <AttachmentPicker type={CONST.ATTACHMENT_PICKER_TYPE.IMAGE}>
+                        <AttachmentPicker
+                            type={CONST.ATTACHMENT_PICKER_TYPE.IMAGE}
+                            shouldValidateImage={false}


Can you please add a comment explaining why we don't need to validate here

comment added.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

srikarparsi

This makes sense to me. The alternative is to do validation in web and native AttachmentPicker but native has a default alert we would have to override.

OSBotify · 2024-10-01T07:30:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-02T00:31:36Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.0.43-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-02T01:10:16Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.0.43-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-03T03:34:27Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.43-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: Profile - No error after uploading corrupted jpg for avatar, con…

34a4d8c

…sole error shows up. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 requested a review from a team as a code owner September 14, 2024 11:48

melvin-bot Bot requested review from Ollyws and removed request for a team September 14, 2024 11:48

Krishna2323 added 5 commits September 14, 2024 18:04

fix error message styling for native.

5651e49

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

updated error message.

fa74969

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fix: corrupt image validation on native.

512555d

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

minor fix.

fa96a9c

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

skip image validation in AttachmentPicker.

f988185

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 commented Sep 14, 2024

View reviewed changes

Ollyws reviewed Sep 17, 2024

View reviewed changes

Krishna2323 mentioned this pull request Sep 19, 2024

[$100] Android -Profile - Error Message Cut Off When Uploading Large Image to Profile #49485

Closed

1 of 6 tasks

Krishna2323 added 2 commits September 24, 2024 01:45

Merge branch 'main' into krishna2323/issue/48707

387c896

minor styling fix.

c6b7bb8

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Ollyws approved these changes Sep 27, 2024

View reviewed changes

melvin-bot Bot requested a review from srikarparsi September 27, 2024 13:12

etCoderDysto mentioned this pull request Sep 27, 2024

Android - Profile - In profile and workspace profile uploading same image shows different error #49796

Closed

1 of 6 tasks

srikarparsi suggested changes Sep 29, 2024

View reviewed changes

Krishna2323 added 2 commits September 30, 2024 06:38

Merge branch 'Expensify:main' into krishna2323/issue/48707

3939e4c

add comment.

72cf668

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

srikarparsi approved these changes Oct 1, 2024

View reviewed changes

srikarparsi merged commit 46dc2ae into Expensify:main Oct 1, 2024

github-actions Bot mentioned this pull request Oct 2, 2024

Deploy Checklist: New Expensify 2024-10-02 #50030

Closed

56 tasks done

melvin-bot Bot mentioned this pull request Oct 3, 2024

[HOLD for payment 2024-10-10] [$250] Profile - No error after uploading corrupted jpg for avatar, console error shows up #48707

Closed

3 of 6 tasks

	const validateAndCompleteAttachmentSelection = useCallback(
	(fileData: FileResponse) => {
	// Check if the file dimensions indicate corruption
	// The width/height for a corrupted file is -1 on android native and 0 on ios native
	// We must check only numeric values because the width/height can be undefined for non-image files
	if ((typeof fileData.width === 'number' && fileData.width <= 0) \|\| (typeof fileData.height === 'number' && fileData.height <= 0)) {
	showImageCorruptionAlert();
	return Promise.resolve();
	}

Conversation

Krishna2323 commented Sep 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Sep 14, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ollyws Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ollyws commented Sep 16, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Krishna2323 Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Krishna2323 commented Sep 23, 2024

Uh oh!

Ollyws commented Sep 27, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

Ollyws left a comment

Choose a reason for hiding this comment

Uh oh!

srikarparsi left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

srikarparsi left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Oct 1, 2024

Uh oh!

github-actions Bot commented Oct 2, 2024

Uh oh!

github-actions Bot commented Oct 2, 2024

Uh oh!

github-actions Bot commented Oct 3, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Krishna2323 commented Sep 14, 2024 •

edited

Loading

Ollyws Sep 25, 2024 •

edited

Loading

Krishna2323 Sep 19, 2024 •

edited

Loading