Skip to content

fix deleted expense still visible offline #49878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasperhuangg merged 6 commits into from
Sep 30, 2024
Merged

fix deleted expense still visible offline #49878

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f2c1714
fix deleted expense still visible offline
huult Sep 28, 2024
b9e4554
chore run prettier
huult Sep 28, 2024
43a4e7c
Merge remote-tracking branch 'upstream/main' into 49329-deleted-expen…
huult Sep 30, 2024
5fef1cb
revert help file and move the DELETE_MONEY_REQUEST command under CLOS…
huult Sep 30, 2024
d0fc60b
revert file index.md
huult Sep 30, 2024
2c98356
delete file index.markdown
huult Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libs/Middleware/SaveResponseInOnyx.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ const requestsToIgnoreLastUpdateID: string[] = [
WRITE_COMMANDS.OPEN_APP,
SIDE_EFFECT_REQUEST_COMMANDS.RECONNECT_APP,
WRITE_COMMANDS.CLOSE_ACCOUNT,
WRITE_COMMANDS.DELETE_MONEY_REQUEST,

@arosiclair arosiclair Dec 19, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasperhuangg @aimane-chnaif @huult hey guys I noticed this change while working on another issue. Similar to another instance here, this is probably the wrong way to fix the bug we were addressing here. This disables reliable updates for DeleteMoneyRequest which can cause reliability issues. Can we revert this and try fixing the root problem another way?

@huult huult Dec 20, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arosiclair We need a backend update. If lastUpdateIDFromClient is less than the previousUpdateID received, the client needs updating.

@arosiclair arosiclair Dec 20, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what change is needed specifically, but lastUpdateIDFromClient and previousUpdateID are not the root problem. Instead we probably need to fix the onyx updates themselves or maybe the way we're rendering them in React.

@arosiclair arosiclair Jan 10, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasperhuangg @aimane-chnaif friendly bump for reverting this. It's critical that we clean this up.

SIDE_EFFECT_REQUEST_COMMANDS.GET_MISSING_ONYX_MESSAGES,
];

Expand Down