Repository navigation
fix: categories subtitle shows undefined settings when there is sync error - #49972
Conversation
|
@mkzie2 were we able to resolve the type error? I'll fill out the checklist after. Thank you :D |
|
@brunovjk Done. |
|
Great work so far @mkzie2. I have just two points before I continue with the checklist: 1 - Do we really need to create a new pull.49972.movThank you very much :D |
|
Excuse @mkzie2 did you have a chance to take a look at my last comment? Thanks. |
Yes. The purpose of this PR is to handle all unsupported integrations though I'm not sure about all their names (only Quickbooks Desktop at the moment). But if there is, we just simply add it to the list and it'll be covered.
Agree. There'll be Categories, Tags, Taxes and Report fields pages. Will update now. Also note that the original issue: "... imported from your undefined settings" was fixed for QBD on |
|
Got it, thanks a lot for the clarification. Great! I'll wait for your update so I can continue with the review. Please let me know if you need anything.
Hmm, I'll take a closer look in a bit, I wonder if it's been fixed for other tabs and connections as well? Thank you very much. |
@brunovjk This is a BE issue, it was fixed from the BE so all tabs are fixed. |
|
Great, very good :D thank you @mkzie2. Do you think we can close the issue then? |
|
@brunovjk Based on #49394 (comment), we have 2 requirements:
The However I have one concern: Currently, when We might not want to fix 1️⃣ but I think we SHOULD fix the issue I just mentioned. The solution is already implemented by this change. Wdyt? |
I agree 100%! Let's stick with the plan :D Maybe we need to update the PR details and test steps? Let me know when I can test it, Thank you. |
|
@brunovjk These test steps in PR description already covered that case: I applied changes to other tabs, you can start testing now. |
Reviewer Checklist
Screenshots/VideosAndroid: Native49972_android_native.movAndroid: mWeb Chrome49972_android_mweb.moviOS: Native49972_ios_native.moviOS: mWeb SafariMacOS: Chrome / Safari49972_web_chorme.movMacOS: Desktop49972_web_desktop.mov |
There was a problem hiding this comment.
Overall the changes seem good to me, however I still wonder if do we need to specify in PolicyUtils.getCurrentConnectionName that we accept includeUnsupportedConnection, nor create a CONST for it. @mkzie2 explained why we need it here, but I would like to know your opinion on this @justinpersaud. Thank you.
|
@justinpersaud TL;DR One of the original issues ("imported from undefined settings" text when integrating QBD) was fixed in BE so basically we won't need the changes that @brunovjk mentioned above. But if we want to prevent future unsupported integrations (QBD used to be unsupported) from reintroducing the |
|
I was just looking internally and it's likely because we just finished supporting Quickbooks in the backend very recently. Personally, I don't think we need to keep the code there for that as it was specific to this use case so I think you can go ahead and remove it. |
|
Great! I agree 100% thank you @justinpersaud :D cc: @mkzie2 |
|
@brunovjk Reverted those changes. |
|
Thank you very much for the changes @mkzie2. I retested and noticed a bug where even with "connection error" Screen.Recording.2024-10-16.at.09.55.06.movI don't believe this bug is related to our PR, it seems more like an issue with the backend, but I can't confirm it. @mkzie2 did you reproduce the same bug or were you able to test everything normally? Thanks again. |
|
@brunovjk I do not face that problem. I got |
Great @mkzie2, I tested it again and this part actually works fine. However, there is one thing, even if the connection is not fully completed in OldDot we initially treat it as if it was successfully completed in NewDot, but we have not yet finished the setup. This leads to a bug where, if in OldDot you close the page before completing the setup, in NewDot we treat it as if it was completed: Screen.Recording.2024-10-17.at.08.04.09.movDo you think we can/should fix this through FE? Thanks a lot. cc: @justinpersaud |
|
Hmm that is pretty minor but I will get a second opinion |
|
Great, besides that everything looks good here @justinpersaud :D Thanks. |
|
I do agree with @justinpersaud it's pretty minor and not a blocker, as the user will complete the setup on NewDot eventually from start to finish when everyone is migrated there. And if an user is on OldDot, he'll complete the flow on OldDot either way and will not have the issue once he's migrated to NewDot. cc @hoangzinh so you're aware of this too. By the way @brunovjk, the error messages weren't correctly pushed to the frontend, it's now the case and wasn't related to this PR. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/justinpersaud in version: 9.0.51-1 🚀
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.51-4 🚀
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.51-4 🚀
|


Details
This PR:
imported from [integration] settingstext when having integration sync errorGo to Expensify Classic to manage your settings.text when synced with unsupported integrationFixed Issues
$ #49394
PROPOSAL: #49394 (comment)
Tests
Get a better overview of where money is being spent...message showsThe categories below are imported from Quickbooks Desktop settings.message showsQuickbooks Desktop settingsGo to Expensify Classic to manage your settings.message shows without any integration menu (Import, Export, Advanced...) or error messageOffline tests
QA Steps
See Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2024-10-02.at.07.42.18.mov
Screen.Recording.2024-10-02.at.14.39.47.mov
MacOS: Desktop