Skip to content

[CP Staging] Ensure that round trips do not display the duplicate waypoint error incorrectly #50084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasperhuangg merged 1 commit into from
Oct 2, 2024
Merged

[CP Staging] Ensure that round trips do not display the duplicate waypoint error incorrectly #50084

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/libs/TransactionUtils/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,7 +646,10 @@ function getValidWaypoints(waypoints: WaypointCollection | undefined, reArrangeI
let waypointIndex = -1;

return waypointValues.reduce<WaypointCollection>((acc, currentWaypoint, index) => {
const previousWaypoint = waypointValues.at(lastWaypointIndex);
// Array.at(-1) returns the last element of the array
// If a user does a round trip, the last waypoint will be the same as the first waypoint
// We want to avoid comparing them as this will result in an incorrect duplicate waypoint error.
const previousWaypoint = lastWaypointIndex !== -1 ? waypointValues.at(lastWaypointIndex) : undefined;

// Check if the waypoint has a valid address
if (!waypointHasValidAddress(currentWaypoint)) {
Expand Down