Repository navigation
[CP Staging] Revert "feat: upload native logs" - #50124
Merged
Merged
Conversation
jasperhuangg
requested review from
mananjadhav
and removed request for
akinwale
October 3, 2024 00:45
mananjadhav
reviewed
Oct 3, 2024
mananjadhav
left a comment
mananjadhav
left a comment
Collaborator
There was a problem hiding this comment.
Did the code check comparing the reverted PR.
Contributor
Author
|
This only needs to be tested on iOS fyi |
Collaborator
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: Nativeios-revert-oslogs_diF4pRvs.mp4ios-revert-logs-with-cpu-usage.mp4iOS: mWeb SafariMacOS: Chrome / Safariweb-revert-oslogs.movMacOS: Desktop |
mananjadhav
approved these changes
Oct 3, 2024
|
@MarioExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
jasperhuangg
changed the title
Beamanator
approved these changes
Oct 3, 2024
OSBotify
pushed a commit
that referenced
this pull request
Oct 3, 2024
[CP Staging] Revert "feat: upload native logs" (cherry picked from commit a6ff319) (CP triggered by Beamanator)
56 tasks done
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.0.43-6 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Contributor
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.43-6 🚀
|
1 of 6 tasks
github-actions
Bot
added
the
DeployBlockerCash
Contributor
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
Contributor
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
Contributor
|
The reported performance regression can be ignored, see: |
Beamanator
removed
the
DeployBlockerCash
Contributor
|
removing deploy blocker due to comment above - thanks @hannojg ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This seems to be causing performance issues so we're going to revert it for now.
Reverts #45905
Fixed Issues
$ #50104
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop