Repository navigation
Feat: Delete workspace with card feed or expensify card - #50152
Conversation
|
bump @ntdiary 🙇♂️ |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-10-06.at.12.51.13.AM.movAndroid: mWeb ChromeWhatsApp.Video.2024-10-06.at.1.00.22.AM.mp4iOS: NativeScreen.Recording.2024-10-06.at.12.37.33.AM.moviOS: mWeb SafariScreen.Recording.2024-10-06.at.12.08.03.AM.movMacOS: Chrome / SafariScreen.Recording.2024-10-05.at.11.33.05.PM.movMacOS: DesktopScreen.Recording.2024-10-06.at.1.07.36.AM.mov |
ishpaul777
left a comment
There was a problem hiding this comment.
Only pending translation conifrmation, rest LGTM!
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #49938 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
lakchote
left a comment
There was a problem hiding this comment.
Translation needs to be adjusted, other than that LGTM
|
@ishpaul777 Do we have any blockers here? |
|
We were discussing this suggestion #50152 (comment) |
|
@waterim merge main when you get chance |
…ce-with-card-feed
|
Updated |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.0.48-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.48-2 🚀
|
| const workspaceAccountID = PolicyUtils.getWorkspaceAccountID(policyIDToDelete ?? '-1'); | ||
| const [cardFeeds] = useOnyx(`${ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER}${workspaceAccountID}`); | ||
| const [cardsList] = useOnyx(`${ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST}${workspaceAccountID}_${CONST.EXPENSIFY_CARD.BANK}`); | ||
| const hasCardFeedOrExpensifyCard = !isEmptyObject(cardFeeds) || !isEmptyObject(cardsList); |
There was a problem hiding this comment.
We also need to consider cardsEnabled value, bcoz card details will be available only after opening the cards page. This missing check caused issue #50671
Details
Fixed Issues
$ #49938
PROPOSAL: N/A
Tests
Offline tests
Same as tests
QA Steps
None
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web, with card feed
Web, without card feed