Repository navigation
Updated selected transaction If getting new updates (also fixed for cases where the status is set to ALL) - #50347
Conversation
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@luacmartins @jjcoffee This PR is a follow-up to #50347 Here’s a breakdown of the changes in this PR:
Lines 320 to 328 in d03066f In the previous PR, we only addressed the cases where report data was returned. In this PR, we’re adding conditions to handle all possible cases.
|
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-10-08.at.12.36.40.AM.movAndroid: mWeb ChromeScreen.Recording.2024-10-08.at.12.34.40.AM.moviOS: NativeScreen.Recording.2024-10-08.at.12.18.35.AM.moviOS: mWeb SafariScreen.Recording.2024-10-08.at.12.22.26.AM.movMacOS: Chrome / SafariScreen.Recording.2024-10-08.at.12.20.54.AM.movMacOS: DesktopScreen.Recording.2024-10-08.at.12.43.42.AM.mov |
|
@cretadn22 please add tests steps for
|
|
@ishpaul777 Waiting a moment, I see a problem about this change |
|
@ishpaul777 I’ve removed the following fix:
I noticed some issues (the hold/unhold action wasn’t working correctly), so I decided to revert this change. Don't worry, this is a separate bug. I initially included it in this PR because I thought it was a minor change. However, we should handle it separately in another PR now. |
|
In the previous PR, @jjcoffee also mentioned that it's out of scope: #49829 (comment) |
Updated selected transaction If getting new updates (also fixed for cases where the status is set to ALL) (cherry picked from commit 4e17806) (CP triggered by thienlnam)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 9.0.45-4 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.45-4 🚀
|
Details
Fixed Issues
$ #50286
PROPOSAL:
Tests
Same QA steps
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen175.mov
Android: mWeb Chrome
Screen174.mov
iOS: Native
Screen173.mov
iOS: mWeb Safari
Screen172.mov
MacOS: Chrome / Safari
Screen171.mov
MacOS: Desktop
Screen170.mov