Repository navigation
[QBD] Handle the syncing for QBD - #50500
Conversation
97f6bd0 to
20c480b
Compare
|
@lakchote It's an edge case but behavior is different between OldDot and ND.
Screen.Recording.2024-10-11.at.23.29.28.mov |
|
You should show an error message: You can check for this error, by verifying if We should not display |
I don't think it's the right direction @lakchote. The initial state of Screen.Recording.2024-10-14.at.18.17.29.movBased on the function to get sync error here, I think BE should return App/src/pages/workspace/accounting/utils.tsx Lines 302 to 306 in 1535588 |
|
@hoangzinh I've raised a PR so the backend properly sets the error message. |
|
Thanks @lakchote. |
| case 'startingImportQBD': | ||
| case 'quickbooksDesktopImportMore': | ||
| return 'Importando datos desde QuickBooks Desktop'; | ||
| case 'quickbooksDesktopImportTitle': | ||
| return 'Importando título'; | ||
| case 'quickbooksDesktopImportApproveCertificate': | ||
| return 'Importando certificado de aprobación'; | ||
| case 'quickbooksDesktopImportDimensions': | ||
| return 'Importando dimensiones'; | ||
| case 'quickbooksDesktopImportSavePolicy': | ||
| return 'Importando política de guardado'; | ||
| case 'quickbooksDesktopWebConnectorReminder': | ||
| return 'Aún sincronizando datos con QuickBooks... Por favor, asegúrate de que el Conector Web esté en funcionamiento'; |
There was a problem hiding this comment.
@hoangzinh it should be good now, can you test it? |
|
It doesn't work @lakchote. I tried to use the staging server, but Pusher event or API didn't return Screen.Recording.2024-10-15.at.16.07.28.mov |
I've taken a look yesterday and today. I'm currently investigating on the best way to approach this. |
|
Pinging you here @hoangzinh to retest in case you've missed my notifications on NewDot. |
|
Okay, I've retested it on my own and it seems to work well @francoisl: Screen.Recording.2024-10-17.at.11.14.07.mov |
|
Sorry @suneox. This PR will be reviewed by @ZhenjaHorbach and @lakchote. This is included in the QBD project |
Reviewer Checklist
Screenshots/VideosAndroid: NativeNA Android: mWeb ChromeNA iOS: NativeNA iOS: mWeb SafariNA MacOS: Chrome / SafariError: web-error.movSuccess: web-done.movMacOS: DesktopError: 2024-10-18.13.46.20.movSuccess: 2024-10-18.13.49.14.mov |
if an user is offline CC: @lakchote |
Agreed. I updated in this commit dc7a92a |
|
Everything seems to be working good ! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.0.51-1 🚀
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.51-4 🚀
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.51-4 🚀
|


Details
Fixed Issues
$ #49698
PROPOSAL:
Tests
Same as Tests
Offline tests
Can't test when offline
QA Steps
Prerequisites: Turn on Beta quickbooksDesktopOnNewDot on your account
In Web/Desktop
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A
Android: mWeb Chrome
N/A
iOS: Native
N/A
iOS: mWeb Safari
N/A
MacOS: Chrome / Safari
Screen.Recording.2024-10-17.at.22.36.42.web.part.1.mov
Screen.Recording.2024-10-17.at.22.34.57.web.part.2.mov
MacOS: Desktop
Screen.Recording.2024-10-17.at.22.40.02.desktop.part.1.mov
Screen.Recording.2024-10-17.at.23.11.04.desktop.part.2.mov