Repository navigation
[No QA] Feat: Adding Direct Card Feed: Selecting stripe feed - #50733
Conversation
|
@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-10-16.at.1.06.51.AM.movAndroid: mWeb ChromeScreen.Recording.2024-10-16.at.1.04.21.AM.moviOS: NativeScreen.Recording.2024-10-16.at.1.09.43.AM.moviOS: mWeb SafariScreen.Recording.2024-10-16.at.1.11.06.AM.movMacOS: Chrome / SafariScreen.Recording.2024-10-16.at.1.01.47.AM.movMacOS: DesktopScreen.Recording.2024-10-16.at.1.02.25.AM.mov |
|
Screen.Recording.2024-10-15.at.11.56.01.PM.mov |
allgandalf
left a comment
There was a problem hiding this comment.
Looks good, just a couple of points ^
|
@allgandalf bug fixed! |
Cool, I guess we can keep it as is for now and if we need we can follow up! |
allgandalf
left a comment
There was a problem hiding this comment.
♻️ Bug fixed, rest flows look great!
Thanks for the work! 🙇
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.51-1 🚀
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.51-4 🚀
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.51-4 🚀
|
|
|
||
| function AddNewCardPage() { | ||
| function AddNewCardPage({policy}: WithPolicyAndFullscreenLoadingProps) { | ||
| const policyID = policy?.id; |
There was a problem hiding this comment.
coming from #60786
we should have added a loading condition

Details
Fixed Issues
$ #50450
PROPOSAL: N/A
Tests
Offline tests
Same as tests
QA Steps
None
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Details