Repository navigation
[NO QA]: Update existing custom feed flow - #50891
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-10-16.at.11.23.52.PM.movAndroid: mWeb ChromeScreen.Recording.2024-10-16.at.11.27.00.PM.moviOS: NativeScreen.Recording.2024-10-16.at.11.10.04.PM.moviOS: mWeb SafariScreen.Recording.2024-10-16.at.11.20.54.PM.movMacOS: Chrome / SafariScreen.Recording.2024-10-16.at.11.01.21.PM.movScreen.Recording.2024-10-16.at.11.02.34.PM.movMacOS: DesktopScreen.Recording.2024-10-16.at.11.06.52.PM.mov |
allgandalf
left a comment
There was a problem hiding this comment.
All the test mentioned test well, even when we refresh the state isn't lost and we are navigated correctly!
Looks good to merge, Thanks for the PR @narefyev91 🙇
|
🎯 @allgandalf, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #50930. |
|
^ asked the BZ to close the payment issue |
# Conflicts: # src/pages/workspace/companyCards/addNew/CardInstructionsStep.tsx # src/pages/workspace/companyCards/addNew/DetailsStep.tsx # src/pages/workspace/companyCards/addNew/SelectBankStep.tsx
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.51-1 🚀
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.51-4 🚀
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.51-4 🚀
|
Details
$ #50451
PROPOSAL:
Tests
Precondition - user should have enabled company cards
For Amex:
For Bank of America, Capital One, Chase, Citibank, Wells Fargo:
For Other bank menu item:
For Brex:
Brex will open direct Bank UI flow - which will be handled in next PR
Offline tests
Same logic as it was done before for Feed V1
QA Steps
Precondition - user should have enabled company cards
For Amex:
For Bank of America, Capital One, Chase, Citibank, Wells Fargo:
For Other bank menu item:
For Brex:
Brex will open direct Bank UI flow - which will be handled in next PR
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android1.mov
Android: mWeb Chrome
android-web1.mov
iOS: Native
ios1.mov
iOS: mWeb Safari
ios-web1.mov
MacOS: Chrome / Safari
web1.mov
MacOS: Desktop
desktop1.mov