Repository navigation
[CP Staging] Update useOnyx() calls to have initWithStoredValues: false - #51207
Conversation
|
@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
useOnyx() calls to have initWithStoredValues: falseuseOnyx() calls to have initWithStoredValues: false
|
I am suggesting that we CP this to staging and get it out as soon as possible. Since it's going to potentially get people stuck and unable to use the app. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[CP Staging] Update `useOnyx()` calls to have` initWithStoredValues: false` (cherry picked from commit f8ecf12) (CP triggered by marcaaron)
|
🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.0.51-4 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.51-4 🚀
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.51-4 🚀
|
Details
cc @tylerkaraszewski who reported this issue today
When we updated the
withOnyx()calls touseOnyx()we missed that several of them had aninitWithStoredValues: falseproperty. This is necessary for the app update logic to work correctly since it should really only respond to errors thrown by the API and never to the values stored in Onyx. In some cases, the value might get stuck in thetrueposition (maybe there is some way to prevent that) and leads to the issue described in the linked issue.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/437830
Tests
updateRequiredto betruevia JS console (Onyx.set('updateRequired', true)) this should lead to the upgrade modal to show.Offline tests
❌
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop