fix: hide Add shipping details if deactivated by truph01 · Pull Request #51230 · Expensify/App

truph01 · 2024-10-22T08:46:35Z

Details

Fixed Issues

$ #50693
PROPOSAL: #50693 (comment)

Tests

Precondition:

User has assigned a physical card to self.
Private details have not been added.

Go to ND
Go to workspace settings > Expensify Card.
Click on the Expensify Card that is assigned to yourself.
Click Deactivate card.
Deactivate the card.
Go to workspace chat.
Verify "Add shipping details" button will not appear since the card is deactivated.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-22.at.16.25.17.mov

Android: mWeb Chrome

Screen.Recording.2024-10-22.at.16.26.44.mov

iOS: Native

Screen.Recording.2024-10-22.at.16.21.56.mov

iOS: mWeb Safari

Screen.Recording.2024-10-22.at.16.23.45.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-22.at.16.11.08.mov

MacOS: Desktop

Screen.Recording.2024-10-22.at.16.20.01.mov

melvin-bot · 2024-10-22T09:27:32Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hoangzinh · 2024-10-23T14:53:00Z

+        action,
+        CONST.REPORT.ACTIONS.TYPE.CARD_ISSUED,
+        CONST.REPORT.ACTIONS.TYPE.CARD_ISSUED_VIRTUAL,
+        CONST.REPORT.ACTIONS.TYPE.CARD_MISSING_ADDRESS,


Should we only check CONST.REPORT.ACTIONS.TYPE.CARD_MISSING_ADDRESS here? Because eventually in line 55, we only check CONST.REPORT.ACTIONS.TYPE.CARD_MISSING_ADDRESS

hoangzinh · 2024-10-23T15:00:37Z

+    const [cardList = {}] = useOnyx(ONYXKEYS.CARD_LIST);
+    const [cardsList] = useOnyx(`${ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST}${workspaceAccountID}_${CONST.EXPENSIFY_CARD.BANK}`);


Do we have other names for cardList and cardsList? They caused me to be confused at first.

hoangzinh · 2024-10-28T23:01:54Z

cc @truph01 on above feedbacks

truph01 · 2024-10-29T08:28:35Z

@hoangzinh I just merged the latest main, so now the PR is just one line change. Can you help review it again?

hoangzinh · 2024-10-30T22:16:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

OSBotify · 2024-10-31T19:44:35Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-04T14:38:37Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.0.57-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-11-06T00:02:10Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.57-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

allgandalf · 2025-03-12T03:29:43Z

    const cardID = cardIssuedActionOriginalMessage?.cardID ?? -1;
    const isPolicyAdmin = PolicyUtils.isPolicyAdmin(PolicyUtils.getPolicy(policyID));
    const card = isPolicyAdmin ? cardsList?.[cardID] : cardList[cardID];
+    const shouldShowAddMissingDetailsButton = !isEmptyObject(card) && action?.actionName === CONST.REPORT.ACTIONS.TYPE.CARD_MISSING_ADDRESS && missingDetails && isAssigneeCurrentUser;


FYI, this was wrong, We have an additional condition compared to the condition to display the message. It is the check isEmptyObject(card)

And in this case, the card isn't created successfully. So the CARDMISSINGADDRESS message still be displayed but the card button isn't displayed.

This caused #55026

fix: hide Add shipping details if deactivated

cbf0885

truph01 marked this pull request as ready for review October 22, 2024 09:27

truph01 requested a review from a team as a code owner October 22, 2024 09:27

melvin-bot Bot requested review from hoangzinh and removed request for a team October 22, 2024 09:27

hoangzinh reviewed Oct 23, 2024

View reviewed changes

fix: conflicts

11d9889

hoangzinh approved these changes Oct 30, 2024

View reviewed changes

melvin-bot Bot requested a review from jasperhuangg October 30, 2024 22:22

jasperhuangg approved these changes Oct 31, 2024

View reviewed changes

jasperhuangg merged commit 1f2cc0f into Expensify:main Oct 31, 2024

github-actions Bot mentioned this pull request Nov 4, 2024

Deploy Checklist: New Expensify 2024-11-04 #51953

Closed

63 tasks done

melvin-bot Bot mentioned this pull request Nov 6, 2024

[HOLD for payment 2024-11-13] [$250] Expensify Card - "Add shipping details" button still appears when the card is deactivated #50693

Closed

6 tasks done

allgandalf reviewed Mar 12, 2025

View reviewed changes

Navigation Menu

Repository navigation

fix: hide Add shipping details if deactivated - #51230

fix: hide Add shipping details if deactivated#51230
jasperhuangg merged 2 commits into
Expensify:mainfrom
truph01:fix/50693

truph01 commented Oct 22, 2024 •

edited

Loading

Uh oh!

melvin-bot Bot commented Oct 22, 2024

Uh oh!

hoangzinh Oct 23, 2024

Uh oh!

hoangzinh Oct 23, 2024

Uh oh!

hoangzinh commented Oct 28, 2024

Uh oh!

truph01 commented Oct 29, 2024

Uh oh!

hoangzinh commented Oct 30, 2024 •

edited

Loading

Uh oh!

OSBotify commented Oct 31, 2024

Uh oh!

github-actions Bot commented Nov 4, 2024

Uh oh!

github-actions Bot commented Nov 6, 2024

Uh oh!

allgandalf Mar 12, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		const [cardList = {}] = useOnyx(ONYXKEYS.CARD_LIST);
		const [cardsList] = useOnyx(`${ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST}${workspaceAccountID}_${CONST.EXPENSIFY_CARD.BANK}`);

Conversation

truph01 commented Oct 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Precondition:

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 22, 2024

Uh oh!

hoangzinh Oct 23, 2024

Choose a reason for hiding this comment

Uh oh!

hoangzinh Oct 23, 2024

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented Oct 28, 2024

Uh oh!

truph01 commented Oct 29, 2024

Uh oh!

hoangzinh commented Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

OSBotify commented Oct 31, 2024

Uh oh!

github-actions Bot commented Nov 4, 2024

Uh oh!

github-actions Bot commented Nov 6, 2024

Uh oh!

allgandalf Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

truph01 commented Oct 22, 2024 •

edited

Loading

hoangzinh commented Oct 30, 2024 •

edited

Loading