Skip to content

[CP Staging] Revert "[Feat] Make it possible to submit expenses to any workspace, whether or not there is a workspace chat" - #51289

Merged
blimpich merged 1 commit into
Expensify:mainfrom
ishpaul777:revert-49412-feat/49344
Oct 22, 2024
Merged

[CP Staging] Revert "[Feat] Make it possible to submit expenses to any workspace, whether or not there is a workspace chat"#51289
blimpich merged 1 commit into
Expensify:mainfrom
ishpaul777:revert-49412-feat/49344

Conversation

@ishpaul777

@ishpaul777 ishpaul777 commented Oct 22, 2024

Copy link
Copy Markdown
Contributor

Reverts #49412

@blimpich
blimpich marked this pull request as ready for review October 22, 2024 19:23
@blimpich
blimpich requested a review from a team as a code owner October 22, 2024 19:23
@melvin-bot
melvin-bot Bot removed the request for review from a team October 22, 2024 19:23
@melvin-bot

melvin-bot Bot commented Oct 22, 2024

Copy link
Copy Markdown

@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@blimpich blimpich changed the title Revert "[Feat] Make it possible to submit expenses to any workspace, whether or not there is a workspace chat" [CP Staging] Revert "[Feat] Make it possible to submit expenses to any workspace, whether or not there is a workspace chat" Oct 22, 2024
@blimpich blimpich mentioned this pull request Oct 22, 2024
Closed
6 of 8 tasks
@blimpich
blimpich merged commit e4fb650 into Expensify:main Oct 22, 2024
@melvin-bot melvin-bot Bot added the Emergency label Oct 22, 2024
@melvin-bot

melvin-bot Bot commented Oct 22, 2024

Copy link
Copy Markdown

@blimpich looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@blimpich

blimpich commented Oct 22, 2024

Copy link
Copy Markdown
Contributor

Straight revert, not an emergency just didn't need to fill out the whole checklist since its a straight revert.

@OSBotify

OSBotify commented Oct 22, 2024

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions Bot added the CP Staging marks PRs that have been CP'd to staging label Oct 22, 2024
OSBotify pushed a commit that referenced this pull request Oct 22, 2024
@blimpich @OSBotify
Merge pull request #51289 from ishpaul777/revert-49412-feat/49344
c19b64d 
(cherry picked from commit e4fb650)

(CP triggered by yuwenmemon)
@github-actions github-actions Bot mentioned this pull request Oct 22, 2024
Closed
74 tasks done
@github-actions

github-actions Bot commented Oct 22, 2024

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 9.0.52-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@ishpaul777 ishpaul777 mentioned this pull request Oct 23, 2024
Closed
2 of 50 tasks
@github-actions

github-actions Bot commented Oct 23, 2024

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.52-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@puneetlath puneetlath puneetlath approved these changes
@blimpich blimpich blimpich approved these changes

Assignees

@ishpaul777 ishpaul777

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ishpaul777 @blimpich @OSBotify @puneetlath