Skip to content

[CP Stag] Add cycle detection to getRootParentReport #51879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dangrous merged 1 commit into from
Nov 1, 2024
Merged

[CP Stag] Add cycle detection to getRootParentReport #51879

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/libs/ReportUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,7 +756,7 @@ function getParentReport(report: OnyxEntry<Report>): OnyxEntry<Report> {
* Returns the root parentReport if the given report is nested.
* Uses recursion to iterate any depth of nested reports.
*/
function getRootParentReport(report: OnyxEntry<Report>): OnyxEntry<Report> {
function getRootParentReport(report: OnyxEntry<Report>, visitedReportIDs: Set<string> = new Set<string>()): OnyxEntry<Report> {
if (!report) {
return undefined;
}
Expand All @@ -766,10 +766,18 @@ function getRootParentReport(report: OnyxEntry<Report>): OnyxEntry<Report> {
return report;
}

// Detect and prevent an infinite loop caused by a cycle in the ancestry. This should normally
// never happen
if (visitedReportIDs.has(report.reportID)) {
Log.alert('Report ancestry cycle detected.', {reportID: report.reportID, ancestry: Array.from(visitedReportIDs)});
return undefined;
}
visitedReportIDs.add(report.reportID);

const parentReport = getReportOrDraftReport(report?.parentReportID);

// Runs recursion to iterate a parent report
return getRootParentReport(!isEmptyObject(parentReport) ? parentReport : undefined);
return getRootParentReport(!isEmptyObject(parentReport) ? parentReport : undefined, visitedReportIDs);
}

/**
Expand Down