Fix crash on Connect bank account page by andriivitiv · Pull Request #51981 · Expensify/App

andriivitiv · 2024-11-04T18:25:26Z

Explanation of Change

Fixes an issue where the getShouldShowContinueSetupButtonInitialValue() function was being called before it was declared. It was working correctly until recent changes in #51718 caused the compiler to generate an invalid code.

In the screenshots below, you can see that the getBankAccountFields() and hasInProgressVBBA() functions are declared within an if statement, which means they might sometimes be undefined.

Before this changes

After this changes

Fixed Issues

$ #51961
PROPOSAL: #51961 (comment)

Tests

Open the app
Go to Workspace settings > Workflows.
Click Connect bank account.
Click Update to USD. If this modal doesn't appear and it says that you have to change the currency, go to Workspace settings > Expensify Card and click Issue new card. This is related to feat: Add a mechanism that allows DEVs to connect nonUSD accounts #50992 and only happens on dev.
Verify the app does not crash.

Offline tests

N/A

QA Steps

Open the app
Go to Workspace settings > Workflows.
Click Connect bank account.
Click Update to USD.
Verify the app does not crash.

PR Author Checklist

Screenshots/Videos

Android: Native

51981.android.native.webm

Android: mWeb Chrome

51981.android.mweb.webm

iOS: Native

51981.ios.native.mp4

iOS: mWeb Safari

51981.ios.mweb.mp4

MacOS: Chrome / Safari

51981.macos.chrome.webm

MacOS: Desktop

51981.macos.desktop.mov

`getShouldShowContinueSetupButtonInitialValue()` was being called before the declaration

melvin-bot · 2024-11-04T18:25:31Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

`Ref values (the `current` property) may not be accessed during render. `

Co-authored-by: DylanDylann <141406735+DylanDylann@users.noreply.github.com>

DylanDylann · 2024-11-05T06:28:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-05.at.13.29.10.mov

Android: mWeb Chrome

Screen.Recording.2024-11-05.at.13.26.43.mov

iOS: Native

Screen.Recording.2024-11-05.at.13.26.27.mov

iOS: mWeb Safari

Screen.Recording.2024-11-05.at.13.25.58.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-05.at.13.25.04.mov

MacOS: Desktop

Screen.Recording.2024-11-05.at.13.25.20.mov

…-bank-account-page Fix crash on Connect bank account page (cherry picked from commit d01138a) (CP triggered by Julesssss)

OSBotify · 2024-11-05T11:27:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-05T12:05:07Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.57-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2024-11-05T23:21:32Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.57-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2024-11-06T00:04:07Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.57-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

Fix crash on Connect bank account page

a266d1e

`getShouldShowContinueSetupButtonInitialValue()` was being called before the declaration

andriivitiv requested a review from a team as a code owner November 4, 2024 18:25

melvin-bot Bot requested review from DylanDylann and removed request for a team November 4, 2024 18:25

andriivitiv added 2 commits November 4, 2024 20:32

Ignore @typescript-eslint/prefer-optional-chain

b293e9f

Revert back to ?. to fix lint error

d935f49

`Ref values (the `current` property) may not be accessed during render. `

DylanDylann reviewed Nov 4, 2024

View reviewed changes

Comment thread src/pages/ReimbursementAccount/ReimbursementAccountPage.tsx Resolved

blimpich mentioned this pull request Nov 4, 2024

[HOLD for payment 2024-11-14] [HOLD for payment 2024-11-13] [$250] Bank account - App crashes when connecting to bank account #51961

Closed

3 of 8 tasks

hungvu193 mentioned this pull request Nov 5, 2024

[NO QA] feat: Step 3 UI #51667

Merged

50 tasks done

DylanDylann reviewed Nov 5, 2024

View reviewed changes

Comment thread src/pages/ReimbursementAccount/ReimbursementAccountPage.tsx Resolved

Add () back

4ae18ab

Co-authored-by: DylanDylann <141406735+DylanDylann@users.noreply.github.com>

DylanDylann approved these changes Nov 5, 2024

View reviewed changes

melvin-bot Bot requested a review from blimpich November 5, 2024 06:28

Julesssss approved these changes Nov 5, 2024

View reviewed changes

Julesssss merged commit d01138a into Expensify:main Nov 5, 2024

Julesssss added the CP Staging marks PRs that have been CP'd to staging label Nov 5, 2024

OSBotify pushed a commit that referenced this pull request Nov 5, 2024

Merge pull request #51981 from CyberAndrii/51961-fix-crash-on-Connect…

a3a7010

…-bank-account-page Fix crash on Connect bank account page (cherry picked from commit d01138a) (CP triggered by Julesssss)

github-actions Bot mentioned this pull request Nov 5, 2024

Deploy Checklist: New Expensify 2024-11-04 #51953

Closed

63 tasks done

andriivitiv deleted the 51961-fix-crash-on-Connect-bank-account-page branch November 5, 2024 12:20

Navigation Menu

Repository navigation

Fix crash on Connect bank account page - #51981

Fix crash on Connect bank account page#51981
Julesssss merged 4 commits into
Expensify:mainfrom
andriivitiv:51961-fix-crash-on-Connect-bank-account-page

andriivitiv commented Nov 4, 2024 •

edited

Loading

Uh oh!

melvin-bot Bot commented Nov 4, 2024

Uh oh!

Uh oh!

Uh oh!

DylanDylann commented Nov 5, 2024 •

edited

Loading

Uh oh!

OSBotify commented Nov 5, 2024

Uh oh!

github-actions Bot commented Nov 5, 2024

Uh oh!

github-actions Bot commented Nov 5, 2024

Uh oh!

github-actions Bot commented Nov 6, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

andriivitiv commented Nov 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 4, 2024

Uh oh!

Uh oh!

Uh oh!

DylanDylann commented Nov 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

OSBotify commented Nov 5, 2024

Uh oh!

github-actions Bot commented Nov 5, 2024

Uh oh!

github-actions Bot commented Nov 5, 2024

Uh oh!

github-actions Bot commented Nov 6, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

andriivitiv commented Nov 4, 2024 •

edited

Loading

DylanDylann commented Nov 5, 2024 •

edited

Loading