Skip to content

Update payments page to use Expensify logo for Expensify Card #5216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iwiznia merged 2 commits into from
Sep 14, 2021
Merged

Update payments page to use Expensify logo for Expensify Card #5216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af19369
update payments page to use Expensify logo for Expensify Card
puneetlath Sep 12, 2021
8e67307
Allow Expensify icon to be normal size
puneetlath Sep 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions assets/images/bankicons/expensify.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 5 additions & 4 deletions src/components/Icon/BankIcons.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {Bank, CreditCard, ExpensifyCard} from './Expensicons';
import {Bank, CreditCard} from './Expensicons';
import AmericanExpress from '../../../assets/images/bankicons/american-express.svg';
import BankOfAmerica from '../../../assets/images/bankicons/bank-of-america.svg';
import BB_T from '../../../assets/images/bankicons/bb-t.svg';
Expand All @@ -8,6 +8,7 @@ import Chase from '../../../assets/images/bankicons/chase.svg';
import CitiBank from '../../../assets/images/bankicons/citibank.svg';
import CitizensBank from '../../../assets/images/bankicons/citizens-bank.svg';
import Discover from '../../../assets/images/bankicons/discover.svg';
import Expensify from '../../../assets/images/bankicons/expensify.svg';
import Fidelity from '../../../assets/images/bankicons/fidelity.svg';
import HuntingtonBank from '../../../assets/images/bankicons/huntington-bank.svg';
import NavyFederalCreditUnion from '../../../assets/images/bankicons/navy-federal-credit-union.svg';
Expand All @@ -28,7 +29,7 @@ import variables from '../../styles/variables';

function getAssetIcon(bankName, isCard) {
if (bankName === 'expensify card') {
return ExpensifyCard;
return Expensify;
}

if (bankName.includes('americanexpress')) {
Expand Down Expand Up @@ -122,8 +123,8 @@ export default function getBankIcon(bankName, isCard) {
bankIcon.icon = getAssetIcon(bankName.toLowerCase(), isCard);
}

// For default icon & expensify (for now) the icon size should not be set.
if (![ExpensifyCard, CreditCard, Bank].includes(bankIcon.icon)) {
// For default icons the icon size should not be set.
if (![CreditCard, Bank].includes(bankIcon.icon)) {
bankIcon.iconSize = variables.iconSizeExtraLarge;
}

Expand Down