[Internal QA] [Workspace Feeds] Pull the workspace feed data from different place in domain_member NVP by VickyStash · Pull Request #52268 · Expensify/App

VickyStash · 2024-11-08T16:08:35Z

Explanation of Change

This PR implements getCompanyFeeds function which returns both custom and direct feeds.

Fixed Issues

$ #52251
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Open the app.
Go to the workspace with active custom feed and open Company cards page.
Make sure the list of the cards is displayed as expected.
Open any card details, make sure it looks as expected.
Try to assign one more card, make sure the flow works correctly.
In the console, past the next code:

Onyx.merge('sharedNVP_private_domain_member_YOUR_WORKSPACE_ACCOUNT_ID', {
    settings: {
        oAuthAccountDetails: {
            'oauth.chase.com': {
                accountList: ['CREDIT CARD...6607'],
                credentials: 'xxxxx',
                expiration: 1730998958,
            },
        },
    },
});

Open the feed switcher and switch to the Chase feed.
Repeat the step 6.
Start the assign card flow from the Chase bank, make sure you see the cards to assign.
Create a new workspace. Enable Company cards feature there and create a new custom feed. Make sure it's pending state looks as expected.

Offline tests

Same, as in the Tests section.

QA Steps

Verify that no errors appear in the JS console

Open the app.
Create a workspace and enable Company cards feature there.
Add Custom feed.
Assign a card inside the custom feed. Make sure it works as expected.
The list of cards should look as expected. Open any of the cards to make sure it looks ok.
Repeat steps 3-5 with a Direct feed.

PR Author Checklist

Screenshots/Videos

Android: Native

android1.mp4

android2.mp4

Android: mWeb Chrome

android_web1.mp4

android_web2.mp4

iOS: Native

ios1.mp4

ios2.mp4

MacOS: Chrome / Safari

web_1.mp4

web2.mp4

web_3.mp4

MacOS: Desktop

desktop_1.mp4

desktop2.mp4

…feeds-data # Conflicts: # src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx

melvin-bot · 2024-11-12T16:14:48Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

VickyStash · 2024-11-12T16:16:34Z

@allgandalf I haven't recorded ios web (Safari) video cause I have some troubles with it. I regularly see the error (on the main branch too). I guess it's something with my setup after long weekends, but could you please check it as well.

ios_web_error.mp4

allgandalf

Okay, great job! few minor comments, but i am confident we can merge this one today!

allgandalf · 2024-11-13T09:17:39Z

@@ -1,4 +1,8 @@
-import * as cardUtils from '@src/libs/CardUtils';


@mountiny can you verify the unit tests, I see them just fine at first glance

allgandalf · 2024-11-13T10:54:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/8f874289-9919-4d3f-831c-dd1cbad18158

Android: mWeb Chrome

Screen.Recording.2024-11-14.at.7.30.56.PM.mov

iOS: Native

Screen.Recording.2024-11-14.at.7.21.56.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-11-14.at.7.28.54.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-14.at.6.28.04.PM.mov

MacOS: Desktop

Screen.Recording.2024-11-14.at.7.05.59.PM.mov

allgandalf · 2024-11-13T10:54:42Z

waiting for the workflows to pass ...

allgandalf · 2024-11-13T15:24:04Z

@VickyStash please mark this one internal QA

VickyStash · 2024-11-13T15:26:24Z

@allgandalf I think I don't have rights to update labels 🤔

allgandalf · 2024-11-13T15:27:23Z

Oh i meant to update the title, @mountiny can add that label

mountiny · 2024-11-13T19:21:47Z

Making a build

github-actions · 2024-11-13T19:42:54Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/52268/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/52268/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/52268/NewExpensify.dmg	https://52268.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

mountiny

Couple small changes requested

allgandalf · 2024-11-14T11:03:23Z

I was able to assign cards from new policy , testing now....

allgandalf

LGTM and tests well, great job with the cleanup @VickyStash 🙇

VickyStash · 2024-11-14T14:13:32Z

@mountiny All yours! I've applied your feedback

mountiny

Thanks! great job!

mountiny · 2024-11-14T14:35:32Z

-        expect(cardUtils.getMonthFromExpirationDateString(longDateSlashed)).toBe(expectedMonth);
-        expect(cardUtils.getYearFromExpirationDateString(longDateSlashed)).toBe(expectedYear);
-    });
+    describe('Expiration date formatting', () => {


dont wanna block on it right now but I think we should look into adding more comments explaining in plain english why certain scenrios are that way as it might not be clear for someone

github-actions · 2024-11-15T14:52:21Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.63-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

joekaufmanexpensify · 2024-11-15T16:02:50Z

@VickyStash I am trying to QA this one, am I supposed to add a chase feed, or is the console snippet you added supposed to show one to me? I tried doing step 6, but don't see a Chase feed.

VickyStash · 2024-11-15T16:16:59Z

@joekaufmanexpensify I think the Tests section was more for the C+ testing, I think you should have the opportunity to test it all over real-life flow, so follow the QA Steps section. It can be any Direct feed, not Chase specifically.

joekaufmanexpensify · 2024-11-15T16:45:52Z

Custom feed part works fine. Running into an issue connecting with Amex, which is only direct feed credentials I have with a card. Discussing.

github-actions · 2024-11-19T00:55:37Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.63-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

Add getCompanyFeeds function which returns both custom and direct feeds

206a681

VickyStash changed the title ~~[Workspace Feeds] Pull the workspace feed data from different place in domain_member NVP~~ [WIP] [Workspace Feeds] Pull the workspace feed data from different place in domain_member NVP Nov 8, 2024

VickyStash mentioned this pull request Nov 8, 2024

[HOLD for payment 2024-11-26] [Workspace Feeds] Pull the direct feed data from different place in domain_member NVP #52251

Closed

VickyStash added 7 commits November 12, 2024 09:42

Merge branch 'refs/heads/main' into VickyStash/feature/52251-get-all-…

1994df0

…feeds-data # Conflicts: # src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx

Code clean-up

c2360d0

Align code with the main

84f1e95

Fix the selectedFeed type considering it can be undefined

e1044bc

Update the types to follow real data

64bd9d5

Add tests

c10bbdf

Update old tests description

5382c64

VickyStash changed the title ~~[WIP] [Workspace Feeds] Pull the workspace feed data from different place in domain_member NVP~~ [Workspace Feeds] Pull the workspace feed data from different place in domain_member NVP Nov 12, 2024

VickyStash marked this pull request as ready for review November 12, 2024 16:14

VickyStash requested a review from a team as a code owner November 12, 2024 16:14

melvin-bot Bot requested review from allgandalf and removed request for a team November 12, 2024 16:14

allgandalf suggested changes Nov 13, 2024

View reviewed changes

VickyStash added 5 commits November 13, 2024 10:37

Minor code improvements

367cdfb

Update conditions

3694181

Add getCustomOrFormattedFeedName utility function

b75026f

Add getCustomOrFormattedFeedName tests

668b6cb

Update isCustomFeed implementation

7dc1a0b

VickyStash changed the title ~~[Workspace Feeds] Pull the workspace feed data from different place in domain_member NVP~~ [Internal QA] [Workspace Feeds] Pull the workspace feed data from different place in domain_member NVP Nov 13, 2024

mountiny added the InternalQA This pull request required internal QA label Nov 13, 2024

mountiny added the Ready To Build label Nov 13, 2024

mountiny assigned VickyStash Nov 14, 2024

mountiny reviewed Nov 14, 2024

View reviewed changes

VickyStash added 3 commits November 14, 2024 09:14

Minor code updates

4aa6297

Update getSelectedFeed tests

07cb200

Use one approach for all feed updates

7649ded

This comment was marked as outdated.

Sign in to view

allgandalf approved these changes Nov 14, 2024

View reviewed changes

melvin-bot Bot requested a review from mountiny November 14, 2024 14:02

mountiny approved these changes Nov 14, 2024

View reviewed changes

mountiny merged commit 4e0bbeb into Expensify:main Nov 14, 2024

github-actions Bot mentioned this pull request Nov 15, 2024

Deploy Checklist: New Expensify 2024-11-15 #52618

Closed

37 tasks done

		@@ -1,4 +1,8 @@
		import * as cardUtils from '@src/libs/CardUtils';

Conversation

VickyStash commented Nov 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 12, 2024

Uh oh!

VickyStash commented Nov 12, 2024

Uh oh!

allgandalf left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

allgandalf Nov 13, 2024

Choose a reason for hiding this comment

Uh oh!

allgandalf commented Nov 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allgandalf commented Nov 13, 2024

Uh oh!

allgandalf commented Nov 13, 2024

Uh oh!

VickyStash commented Nov 13, 2024

Uh oh!

allgandalf commented Nov 13, 2024

Uh oh!

mountiny commented Nov 13, 2024

Uh oh!

github-actions Bot commented Nov 13, 2024

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

allgandalf commented Nov 14, 2024

Uh oh!

This comment was marked as outdated.

allgandalf left a comment

Choose a reason for hiding this comment

Uh oh!

VickyStash commented Nov 14, 2024

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny Nov 14, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Nov 15, 2024

Uh oh!

joekaufmanexpensify commented Nov 15, 2024

Uh oh!

VickyStash commented Nov 15, 2024

Uh oh!

joekaufmanexpensify commented Nov 15, 2024

Uh oh!

github-actions Bot commented Nov 19, 2024

Uh oh!

Reviewers

VickyStash commented Nov 8, 2024 •

edited

Loading

allgandalf commented Nov 13, 2024 •

edited

Loading