Skip to content

Add patch to enable allowRecursiveCommitsWithSynchronousMountOnAndroid feature flag #52732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rlinoz merged 2 commits into from
Nov 20, 2024
Merged

Add patch to enable allowRecursiveCommitsWithSynchronousMountOnAndroid feature flag #52732

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6ca14f
Add patch to enable allowRecursiveCommitsWithSynchronousMountOnAndroi…
QichenZhu Nov 18, 2024
fa8281f
Remove comments
QichenZhu Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions ...s/react-native+0.75.2+021+allow-recursive-commits-with-synchronous-mount-on-android.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
diff --git a/node_modules/react-native/ReactAndroid/src/main/jni/react/fabric/Binding.cpp b/node_modules/react-native/ReactAndroid/src/main/jni/react/fabric/Binding.cpp
index 280ae46..572fb3d 100644
--- a/node_modules/react-native/ReactAndroid/src/main/jni/react/fabric/Binding.cpp
+++ b/node_modules/react-native/ReactAndroid/src/main/jni/react/fabric/Binding.cpp
@@ -483,8 +483,10 @@ void Binding::schedulerShouldRenderTransactions(
return;
}

- if (ReactNativeFeatureFlags::
- allowRecursiveCommitsWithSynchronousMountOnAndroid()) {
+ // Avoid freeze and crash caused by deadlock.
+ // Remove this patch after the feature flag is enabled by default.
+ // See: https://github.com/Expensify/App/issues/52496
+ if (true) {
std::vector<MountingTransaction> pendingTransactions;

{