Skip to content

Fix: Inbox - Blue frame on search icon after returning from finder with device back button #52943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
madmax330 merged 7 commits into from
Nov 27, 2024
Merged

Fix: Inbox - Blue frame on search icon after returning from finder with device back button #52943

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
35dc711
Fix: Inbox - Blue frame on search icon after returning from finder wi…
nyomanjyotisa Nov 22, 2024
b9ddd74
minor fix
nyomanjyotisa Nov 22, 2024
3befd90
minor fix
nyomanjyotisa Nov 22, 2024
01dbd45
minor fix
nyomanjyotisa Nov 22, 2024
5bc0fad
minor fix
nyomanjyotisa Nov 22, 2024
0729e21
lint fix
nyomanjyotisa Nov 22, 2024
6b36d4b
ESLint fix
nyomanjyotisa Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/components/Search/SearchRouter/SearchButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react';
import type {StyleProp, ViewStyle} from 'react-native';
import React, {useRef} from 'react';
import type {StyleProp, View, ViewStyle} from 'react-native';
import Icon from '@components/Icon';
import * as Expensicons from '@components/Icon/Expensicons';
import {PressableWithoutFeedback} from '@components/Pressable';
Expand All @@ -22,14 +22,19 @@ function SearchButton({style}: SearchButtonProps) {
const theme = useTheme();
const {translate} = useLocalize();
const {openSearchRouter} = useSearchRouterContext();
const pressableRef = useRef<View>(null);

return (
<Tooltip text={translate('common.search')}>
<PressableWithoutFeedback
ref={pressableRef}
nativeID="searchButton"
accessibilityLabel={translate('common.search')}
style={[styles.flexRow, styles.touchableButtonImage, style]}
// eslint-disable-next-line react-compiler/react-compiler
onPress={Session.checkIfActionIsAllowed(() => {
pressableRef?.current?.blur();

Timing.start(CONST.TIMING.OPEN_SEARCH);
Performance.markStart(CONST.TIMING.OPEN_SEARCH);

Expand Down