Repository navigation
[NoQA][GR Phase 3] Step 5 - navigation, default data, logic and API call to save it #53053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
madmax330
merged 191 commits into
Expensify:main
from
callstack-internal:feat/50907-GR-Phase3-Step5-nav-api-call
Apr 15, 2025
Merged
Changes from all commits
Commits
Show all changes
191 commits
Select commit
Hold shift + click to select a range
81e594c
step 3 implementation applied
burczu 5f213c7
getting corpay onboarding fields call added to signer info page
burczu aadaf97
unnecessary api call prevented
burczu 8aaecc4
save corpay onboarding director information endpoint handling
burczu a1f0be5
prettier fixes
burczu 8c0dff5
save director information api call temp
burczu fa24353
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu 5801d10
Merge branch 'feat/step-3-logic' into feat/50907-GR-Phase3-Step5-nav-…
burczu cb68762
duplicated import removed
burczu 4d18148
switched to destination country
burczu 68de54a
Merge branch 'feat/step-4-logic' into feat/50907-GR-Phase3-Step5-nav-…
burczu 50a07f6
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu 5172a67
Merge branch 'feat/step-4-logic' into feat/50907-GR-Phase3-Step5-nav-…
burczu df189c0
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu e9d25fe
Merge branch 'feat/step-4-logic' into feat/50907-GR-Phase3-Step5-nav-…
burczu dcdbe8f
sending documents added
burczu 62e531a
onyx data handling added to the save director information action
burczu eb9681b
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu 531be87
body content usage fixed
burczu e65b3c3
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu 93444f5
use callback wrapper utilized
burczu 993afee
Merge branch 'feat/step-4-logic' into feat/50907-GR-Phase3-Step5-nav-…
burczu 517f4af
removing files fixed
burczu 3f4a312
error utils usage fixed
burczu 7e8bb10
uploading documents improved
burczu 9498a17
temporary files
burczu 4f9903b
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu 68908c4
Merge branch 'feat/step-4-logic' into feat/50907-GR-Phase3-Step5-nav-…
burczu 0ffd2f0
address page added
burczu adbe1db
temporary skipping step 4
burczu ac45216
address added to the confirmation substep
burczu 10f36d8
wip: merging signer address from onyx and draft
burczu 3cd18dc
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu f306b4a
Merge branch 'feat/step-4-logic' into feat/50907-GR-Phase3-Step5-nav-…
burczu fbe81a2
get signer address value extracted to separate utils and wrapped up
burczu ef0969f
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu c4ce465
get signer details and files utility method scaffolded
burczu 8231d04
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu 3a43bc7
step 4 enabled back
burczu 1defa28
address prefixes adjusted to new reqs
burczu 6adcb61
signer data shape adjusted
burczu d92f373
signer details helper created
burczu 670bbb2
new version of signer params
burczu 6e2bb38
signer info helper refactored
burczu 84accc3
save signer info API call adjusted to the new shape of payload
burczu cd985d8
calling API call with data prepared with new helper
burczu 901dabe
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu 5d45d74
address component adjusted to the new Onyx keys shape
burczu 45c65cb
getting address values fixed
burczu 976e41d
getting signer details for signer info fixed
burczu 023aaa9
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu 080492b
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu 73a9bdf
unnecessary address helper removed
burczu 27ed2ec
collecting signer email as account primary login added
burczu 0f92358
occupation step added
burczu 7dd79a0
reimbursement account form signer info type adjusted
burczu b4e4cce
collecting additional data of current user handled
burczu 0bb82d2
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu b56ec2c
proof of directors collecting added
burczu 4bc87bb
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu 692ed1d
upload signer info files depending on country (WIP)
burczu 00ecd67
missing file uploaders added
burczu b60d7ac
confirmation step cleanup
burczu 5b29968
confirmation page addjusted to the new payload shape
burczu 03164a2
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu ca6e1fe
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu 4301087
director details flow added [WIP]
burczu c332975
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu d2ec22b
prettier changes
burczu 9d5cb3d
collecting additional directors details substeps
burczu 387f52a
directors details substeps cleanup
burczu 47ee7d6
enter email component fixed
burczu de3d4b2
missing second signer corpay field added
burczu eb2d71c
multiple directors list confirmation page added (WIP)
burczu 732321a
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu 0f94f41
filtering current user from additional directors list
burczu 7a6c3e2
additional directors handling when it comes to the API call
burczu 6aecc0e
unnecessary comment removed
burczu 2682f12
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu 650ae0a
flow changed to handle only one additional director
burczu 62a3629
prettier fixes
burczu 5082896
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu c8e3288
additional fixes after merge
burczu 92b9c38
linter fixes
burczu caf125a
unnecessary console.logs removed
burczu ed1041f
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu 6b9c338
linting error fixed
burczu 3b5f0ea
typescript fixes
burczu 6809597
editing additional director fix
burczu d17d902
resetting director details form on entering edit mode added
burczu 6495bb2
is loading handling while saving signer info added (wip)
burczu 078dafe
upload documents fixed
burczu 829dc2d
typings fix
burczu 4dc7c26
showing loading indicator while saving
burczu a9c709d
signer and director prefixes added to consts
burczu 3189471
upload files step polished
burczu 4a113f8
document uploading styling fixed
burczu 4c05d58
missing director prefix usage fixed
burczu 79a1bba
additional prefix fix
burczu 2f3d7c8
get values for signer info director key obtaining fixed
burczu 1b08715
typo fixed
burczu 6548b70
typecheck issues fixed
burczu 4569320
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu c7115da
typings fix after merge
burczu 72fb766
linting errors fixed
burczu 8f01114
prettier fixed
burczu 0bef699
error handling on documents uploading page added
burczu 7ad6814
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu bfd2518
using beneficial owner data for signer when applicable
burczu 97a4de7
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu 784c114
linter errors fixed
burczu a643b50
prettier errors fixed
burczu 013c51f
upload documents slightly fixed
burczu 48ee7a2
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu 37dd2d5
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu d6b4c91
occupation field at confirmation page fixed
burczu 8172a4c
typing fix
burczu 716fd1b
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu 6d5e1fc
beneficial owner data collecting fixed
burczu 7ef3fa6
back button handling fixed
burczu e93bd14
different copy for sub-steps when collecting director details
burczu 20d1d81
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu 2feed69
paddings fixed on upload page separators
burczu 3600887
separator padding fixed on document upload on step 4
burczu 68f4e8e
useCallback deps list updated
burczu 2f1d6dc
prettier fix
burczu c897ef7
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu aa3ee62
missing optional properties added to API params
burczu da82bec
unnecessary comment removed
burczu 92145f2
director list translation props added (WIP)
burczu f518db8
sub-steps director's flow translations (WIP)
burczu b584f06
missing comma
burczu 1f214d1
add additional director translations added (WIP)
burczu 07641ef
unnecessary comment removed
burczu 9dfd2a7
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu 04a9374
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu 0b14888
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu 97780f2
country step country value fixed on upload file
burczu 7974137
occupation error message fixed (WIP)
burczu 463f7da
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu 1c628f5
merge from main
burczu 15e8041
Merge remote-tracking branch 'origin/main' into feat/50907-GR-Phase3-…
burczu 5e7be4f
prd and fsg needed check fixed
burczu 669e260
FSDandPDS typo fixed
burczu 8948c3b
proof of directors copy
burczu 6c0dbbb
copy of ID copy
burczu f56315f
codice fiscale copy
burczu 85e0900
pds and fsg copy
burczu 7090355
switched to download button (WIP)
burczu 4917ffc
Merge remote-tracking branch 'origin/main' into feat/50907-GR-Phase3-…
burczu c75c10b
download button alignment fixed
burczu 88fd779
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu 10a7d86
collecting PRD & FSG removed for now
burczu 2bfec19
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu 144faaf
prettier fixes
burczu d2a1001
tscheck fix
burczu 12cab81
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu 7bd4687
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu f59e949
switch to file uploads per director - first step
burczu 8d1850f
showing upload file page for other director
burczu d1b3db0
passing files correctly
burczu e41a0da
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu f559b8c
file limit introduced
burczu a5aaf92
name step component simplified
burczu e72bc26
job title step component simplified
burczu 8f2ea26
occupation step component removed
burczu 5fdf868
additional director flow removed from index
burczu becfd1d
payload creating adjusted to simplified version
burczu 1274de0
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu cf6dc67
step 5 for Australia handling fixed
burczu f3b20a3
correctly redirecting to the provide email page for AUD
burczu 699db44
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu 5cb0164
prettier fixes
burczu 9082b05
liting fixes
burczu 490b5f8
unnecessary translations removed
burczu 3bcfadb
eslint error fixed
burczu 669f800
items order on confirmation page fixed
burczu 893b59b
JamieGPT translations added
burczu 1dd5ac9
prettier fix
burczu 0e373e1
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu 6222833
loading and errors handling inside the confirmation page added
burczu 983a496
error handling fixed
burczu 738da05
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu 9d31c9f
CAD case fixed
burczu cc49908
Merge branch 'main' into feat/50907-GR-Phase3-Step5-nav-api-call
burczu 8c5309b
unnecessary skip of file uploads removed
burczu 6082db3
allow multiple issue fixed
burczu 2f8bc03
spanish translations updated
burczu 14a3028
unnecessary directorIDs property removed from payload
burczu 52f961a
hook deps fixed
burczu 60d7a02
unnecessary code removed
burczu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
src/libs/API/parameters/SaveCorpayOnboardingDirectorInformationParams.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| import type {FileObject} from '@components/AttachmentModal'; | ||
|
|
||
| type SaveCorpayOnboardingDirectorInformationParams = { | ||
| inputs: string; | ||
| proofOfDirectors?: FileObject; | ||
| addressProof?: FileObject; | ||
| copyOfID?: FileObject; | ||
| codiceFiscaleTaxID?: FileObject; | ||
| bankAccountID: number; | ||
| }; | ||
|
|
||
| export default SaveCorpayOnboardingDirectorInformationParams; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a handler for the button on the last screen below, on the right:
I presumed I will call the
AskForCorpaySignerInformationendpoint, is it correct? And this is part of another issue, will be done in separate PR after we merge this one.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok yeah, sounds good