Repository navigation
[No QA] Create expensify-api.md - #53412
Conversation
|
@puneetlath Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
A preview of your ExpensifyHelp changes have been deployed to https://39eaef0c.helpdot.pages.dev ⚡️ |
|
I'm not 100% sure why the page total and menu item are lower case. I have changed the filename, but I'm taking a stab in the dark. If you know what controls this @puneetlath please let me know! |
|
The |
I don't see what you're seeing @RachCHopkins. It shows up with proper caps for me.
|
I'm not sure what this is in reference to. Is this something you're doing? |
|
@puneetlath Stylistically, I think that this looks kinda weird. Like, it's not obvious enough what it's doing: But that's probably a question for the design team. |
|
Agreed. Can you ask them? |
|
@puneetlath I can (and I will), but I don't think the styles for the whole help site should hold up this one doc! If the style is later changed it will still apply! |
|
Are there any other pages that use this type of code? I would guess that this is one of the only pages affected and ideally we can fix the formatting while creating the page, rather than after. |
|
@puneetlath yes there are other pages that use this styling, but not to this extent. It's the style for the whole help site, I don't think we should hold up this one help page, as we're unlikely to change the style in the nery near term. |
|
Ok gotcha. And where is that being tracked? I want to make sure it's not going to fall through the cracks if I merge this. |
|
Have added it here per design team! |
|
proposals to fix this are happening here - #54227 |
|
Ok, thanks for creating that. I'm going to go ahead and merge this then. |
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.77-0 🚀
|
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.77-6 🚀
|



Explanation of Change
New help doc of API FAQs
Fixed Issues
https://github.com/Expensify/Expensify/issues/414951
Tests
None
Offline tests
None
QA Steps
None
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videosundefined